Bug 280966 - www.foo shouldn't be highlighted as link
Summary: www.foo shouldn't be highlighted as link
Status: CONFIRMED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.7.7
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 00:29 UTC by Nicolás Alvarez
Modified: 2020-12-01 07:06 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolás Alvarez 2011-08-29 00:29:06 UTC
With the new URL regex, "www.foo" is considered a link, along with any two-component domain name that starts in 'www'. I think they shouldn't be linkified, the chances are nil that they are valid and intentional URLs. It's more likely that the sender missed the TLD or introduced a space in the middle of the domain name.

www.com is a valid and registered domain name, but if there is a good reason for Konversation to mark it as a link, google.com should be a link too.

Using Konversation fed58f1d (+ local unrelated patches).
Comment 1 Justin Zobel 2020-11-30 02:38:54 UTC
A change like this would be bad for those that use IRC internally in their organisation and send internal links. ie dev-server.local
Comment 2 Nicolás Alvarez 2020-11-30 03:37:37 UTC
This bug report is specific to hostnames starting with 'www'.

google.com and dev-server.local are already not highlighted as links. Maybe they should be, but that's a separate issue. As long as those aren't linkified, it doesn't make much sense that www.blah is.
Comment 3 Justin Zobel 2020-12-01 03:59:48 UTC
Internal domains can have subdomains as well so www.somedevserver.local could also be used.
Comment 4 Nicolás Alvarez 2020-12-01 04:18:41 UTC
Yes, and that works and can continue to work.

This is the current state:
google.com            nothing
google.com/search     clickable link
www.google.com        clickable link
dev-server.foo        nothing
test.dev-server.foo   nothing
www.dev-server.foo    clickable link
www.foo               clickable link <-- this is what this bug is about, I think this shouldn't be a link

As I said "two-component domain name that starts in 'www'".
Comment 5 Justin Zobel 2020-12-01 07:06:33 UTC
Ahh OK my apologies. Confirmed on 1.7.7.