Version: 1.7 OS: MS Windows String::Prepare(Type t) function wrongly checks the BOM when passing UTF16 type. if(d->data.size() >= 1 && (d->data[0] == 0xfeff || d->data[0] == 0xfffe)) { bool swap = d->data[0] != 0xfeff; If input data is Little Endian on a Little Endian system, no swap will be performed, as on a LE system, a 16 bit value containing [byte0 = 0hFF, byte 1 = 0hFE] will be interpreted as 0xFEFF. So this means that using this code, internal representation is the same endianness as the platform on which it's used. The documentation says that internal representation of TagLib::String is UTF16BE. Reproducible: Always Steps to Reproduce: store a Little Endian string with BOM prefix in a wchar_t buffer and construct a new TagLib::String object specifying the UTF16 Type. Actual Results: when debug tracing, you'll notice that the data won't be converted as it should be according the doc. internal data buffer will remain UTF16 LE. Expected Results: Each wchar_t input elements's bytes should be swapped. A fix could be, in tstring.cpp: void String::prepare(type t) switch(t) { case UTF16: { if(d->data.size() >= 1 && (d->data[0] == 0xfeff || d->data[0] == 0xfffe)) { bool swap = d->data.data()[0] == '\xff';
The fix I proposed doesnt work, it should rather be : void String::prepare(type t) switch(t) { case UTF16: { if(d->data.size() >= 1 && (d->data[0] == 0xfeff || d->data[0] == 0xfffe)) { bool swap = ((const char*)(d->data.c_str()))[0] == '\xff'; (In reply to comment #0) > Version: 1.7 > OS: MS Windows > > String::Prepare(Type t) function wrongly checks the BOM when passing UTF16 > type. > if(d->data.size() >= 1 && (d->data[0] == 0xfeff || d->data[0] == 0xfffe)) { > bool swap = d->data[0] != 0xfeff; > If input data is Little Endian on a Little Endian system, no swap will be > performed, as on a LE system, a 16 bit value containing [byte0 = 0hFF, byte 1 = > 0hFE] will be interpreted as 0xFEFF. > So this means that using this code, internal representation is the same > endianness as the platform on which it's used. The documentation says that > internal representation of TagLib::String is UTF16BE. > > > Reproducible: Always > > Steps to Reproduce: > store a Little Endian string with BOM prefix in a wchar_t buffer and construct > a new TagLib::String object specifying the UTF16 Type. > > > Actual Results: > when debug tracing, you'll notice that the data won't be converted as it should > be according the doc. internal data buffer will remain UTF16 LE. > > Expected Results: > Each wchar_t input elements's bytes should be swapped. > > A fix could be, in tstring.cpp: > void String::prepare(type t) > switch(t) { > case UTF16: > { > if(d->data.size() >= 1 && (d->data[0] == 0xfeff || d->data[0] == 0xfffe)) { > bool swap = d->data.data()[0] == '\xff';
I'd say the correct fix is to change the documentation.
(In reply to comment #2) > I'd say the correct fix is to change the documentation. Well, I'd say it wouldn't be consistent, considering that if you use the same String constructor with type t = UTF16LE, bytes are indeed swapped to be internally stored as UTF16BE this time.
Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone!
Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone!
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!