Bug 279701 - Scripting support for the equaliser
Summary: Scripting support for the equaliser
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Tools/Equalizer (show other bugs)
Version: unspecified
Platform: Unlisted Binaries All
: NOR wishlist
Target Milestone: 2.5
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-08 22:30 UTC by Ryan McCoskrie
Modified: 2014-02-26 17:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan McCoskrie 2011-08-08 22:30:16 UTC
Version:           unspecified
OS:                All

This is a very flexible approach to adding features such as the one in bug #129374. At this time of writing Amarok scripts can play, pause, stop, re-label and even delete music. However they can not be used to tweak how music sounds. Allowing the scripts to adjust the equaliser will open Amarok up to even more dramatic possibilities.

Reproducible: Always

Steps to Reproduce:
Take a quick look at the API

Actual Results:  
No changes to the equaliser via scripting.

Expected Results:  
Ability to adjust how tracks sound just like starting and stopping tracks.

I've started looking into doing this but I don't know if I am up to it.
Comment 1 Anmol Ahuja 2013-05-02 16:43:24 UTC
Can I ask what you plan to do with access to the equalizer in the scripting API?

My GSoC proposal has to do with revamping the scripting API, so I wanted to know what the Amarok scripting community wants.
Comment 2 Anmol Ahuja 2014-02-26 17:29:59 UTC
Git commit 88e0cb75c79e89e596ccd78fe6c8703bc984c20a by Anmol Ahuja.
Committed on 13/08/2013 at 10:20.
Pushed by anmolahuja into branch 'master'.

Refactor equalizer, add scripting support for the equalizer.

M  +4    -2    src/CMakeLists.txt
M  +8    -133  src/EngineController.cpp
M  +4    -30   src/EngineController.h
M  +45   -45   src/dialogs/EqualizerDialog.cpp
M  +4    -8    src/dialogs/EqualizerDialog.h
M  +2    -7    src/equalizer/EqualizerPresets.cpp
M  +9    -0    src/equalizer/EqualizerPresets.h
A  +264  -0    src/playback/EqualizerController.cpp     [License: GPL (v2+)]
A  +120  -0    src/playback/EqualizerController.h     [License: GPL (v2+)]
M  +3    -0    src/scripting/scriptengine/AmarokEngineScript.cpp
A  +144  -0    src/scripting/scriptengine/AmarokEqualizerScript.cpp     [License: GPL (v2+)]
A  +138  -0    src/scripting/scriptengine/AmarokEqualizerScript.h     [License: GPL (v2+)]

http://commits.kde.org/amarok/88e0cb75c79e89e596ccd78fe6c8703bc984c20a