Bug 279602 - changing identity breakes e-mail content
Summary: changing identity breakes e-mail content
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kmail2
Classification: Applications
Component: composer (show other bugs)
Version: 4.10.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-07 18:11 UTC by Silver Salonen
Modified: 2017-01-07 22:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Silver Salonen 2011-08-07 18:11:00 UTC
Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

I have multiple identities with different signatures. When I compose an e-mail and change signature meanwhile, the previous signature gets replaces with a new one, but if the e-mail has the content of the 1st signature anywhere else, that elsewhere locating content gets replaces too.

Reproducible: Always

Steps to Reproduce:
1) Create multiple identities with different signatures
2) Open an e-mail that contains something from one of the signatures
3) Start replying to that e-mail
4) Change identity

Actual Results:  
Content that is identical to the current signature (eg. 'Silver') gets replaced by the new signature.

Expected Results:  
Only signature should be replaced.
Comment 1 Laurent Montel 2011-08-08 15:51:09 UTC
Why do you create a mail with the content of your other signature ?:)
Comment 2 Silver Salonen 2011-08-08 17:57:39 UTC
Well, one of my signatures is just "Silver" and it happens to be my default identity. When I reply to my own e-mail, it has "On whatever date Silver Salonen wrote:" at the beginning. Then I change my identity that has some more official signature and that "Silver Salonen wrote" is changed to "  Salonen wrote:" and the new signature is placed twice at the top of the quoted text.

BTW, this has been like this for many years, but I've taken it just as something that KMail does. It's still a bug though.
Comment 3 Silver Salonen 2012-01-31 11:02:14 UTC
Still relevant in 4.8.0.
Comment 4 Silver Salonen 2012-02-02 10:16:32 UTC
One more symptom.
I have a signature "Silver" and when I start forwarding an e-mail, my name is deleted from everywhere (or most places) in the contents and these deleted instances of my name are put where the signature should be at.

Cannot KMail somehow remember where did it insert the signature and replace the signature only in there, if necessary? And doing some substitution on the beginning of forwarding an e-mail (without even changing identity) is unnecessary, isn't it?
Comment 5 Silver Salonen 2012-02-08 09:45:56 UTC
This is very annoying, I can't properly answer e-mails if I have a signature with my name configured, because the e-mail contents is altered.
I'd change the priority of this bug to MAJOR if I could.
Comment 6 Silver Salonen 2012-11-15 08:58:48 UTC
Still relevant in 4.9.3.
Comment 7 Silver Salonen 2012-11-16 10:28:29 UTC
Another interesting issue:
1) I have set my signature to 'Silver'
2) I have disabled signature (without deleting it first)
3) When I reply to message that has my signature "Silver" in the content many-many times (as it's back-and-forth e-mail thread), all the signatures are deleted (just "--" is left in place)
Comment 8 Laurent Montel 2012-11-16 10:46:58 UTC
(In reply to comment #7)
> Another interesting issue:
> 1) I have set my signature to 'Silver'
> 2) I have disabled signature (without deleting it first)

How ?

> 3) When I reply to message that has my signature "Silver" in the content
> many-many times (as it's back-and-forth e-mail thread), all the signatures
> are deleted (just "--" is left in place)

So what do you want ? Remove it or not ?
Comment 9 Silver Salonen 2012-11-16 10:55:28 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Another interesting issue:
> > 1) I have set my signature to 'Silver'
> > 2) I have disabled signature (without deleting it first)
> 
> How ?

By unticking "Enable signature" :)

> > 3) When I reply to message that has my signature "Silver" in the content
> > many-many times (as it's back-and-forth e-mail thread), all the signatures
> > are deleted (just "--" is left in place)
> 
> So what do you want ? Remove it or not ?

No, of course not. I'll make it clearer.

I have an e-mail like this:
----------
Hi Silver.

bla-bla.

--
Someone

On some date you wrote:
> Hi Someone
> Bla-bla.
> 
> --
> Silver
----------

When I click reply to that e-mail, composer shows:
----------

--


On some date you wrote:
> Hi Silver.
> 
> bla-bla.
> 
> --
> Someone
> 
> On some date you wrote:
>> Hi Someone
>> Bla-bla.
>>
>> --
>>
----------

PS. My reply-template is set to:
----------
%CURSOR

--
%SIGNATURE

%REM="Default reply template"%-
On %ODATE %OTIMELONG you wrote:
%QUOTE
----------
Comment 10 Laurent Montel 2012-11-16 10:58:26 UTC
Ok it removes your signature even if it's disabled.
OK I saw.
Comment 11 Silver Salonen 2012-12-05 07:56:46 UTC
The simplest thing would be to at least limit the replacing to only 1 occurrence. Because there is no reason to replace all the occurrences of the signature, even if the signature-to-be-replaced is found elsewhere in the document.
If signature is configured to be added at the end, the replacement should start from the end.
Comment 12 Silver Salonen 2013-03-15 08:59:54 UTC
Still happens in KDE 4.10.
Comment 13 Laurent Montel 2013-03-15 09:10:54 UTC
oops I forgot to look at it.
Will add to my todo-list for 4.10.2 (I hope)
Comment 14 Denis Kurz 2016-09-24 18:16:22 UTC
This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of kmail2 (version 5.0 or later, as part of KDE Applications 15.12 or later), it gets closed in about three months.
Comment 15 Denis Kurz 2017-01-07 22:30:27 UTC
Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.