Version: SVN trunk (using KDE 4.6.0)
The accounts view is not updated after changes to an account.
Steps to Reproduce:
Select the accounts view, select an account, select 'Account/Edit' and change the name. Press OK.
Name in accounts view is not updated.
Name in accounts view is updated.
Changing the name of a category in the categories view updates the name in the view.
Created attachment 62582 [details]
This patch fixed the problem but should receive a bit of review before committing it right before the release
The bug only affect accounts which are marked as 'Favorite'.
This happens because there are actually 2 items for such accounts in the accounts model. In the future the 'Favorites' account grouping should be done in a proxy (as if that would be easier :):)).
The fix consist in internal API change. The function which was used to retrieve the account item by id (when the parent item was not known) now always returns the account which is not the child of the 'Favorite accounts' item.
In the client code of this API in all the relevant places when an account is favorite the corresponding item is also updated explicitly.
Created attachment 62584 [details]
Updated the patch to handle the changing of the 'Favorite' status of the account
SVN commit 1245224 by conet:
Update all the model items even if an account is favorite in which case there are two items which correspond to the same account. This is another case of account data change that affects the model layout that was not handled correctly.
And extra fix of the AccountsFilterProxyModel::removeAccountType which now really removes the account type even if the type is present in the list more then once (m_typeList should really be a set).
M +28 -8 accountsmodel.cpp
WebSVN link: http://websvn.kde.org/?view=rev&revision=1245224