Bug 279444 - Missing progress information when updating date on several images
Summary: Missing progress information when updating date on several images
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-TimeAdjust (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-08-05 12:24 UTC by Vincent Tassy
Modified: 2018-09-22 08:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.6.0

Attachments
Patch for the timeadjust progress bar feature (2.16 KB, patch)
2012-03-24 11:13 UTC, Adrian Nitu 		Details
Updated patch (using kpprogresswidget) (2.63 KB, patch)
2012-03-26 13:59 UTC, Smit Mehta 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Tassy 2011-08-05 12:24:00 UTC 
Version:           2.0.0 (using KDE 4.6.5) 
OS:                Linux

When using the Adjust Time & Date dialog on a series of images, once pressing ok, you have no idea about what digikam is doing ... no progress information ... so you don't know whether it's going through le updates, if it's crashed or anything else ...
It would be great  to have a little progress bar in the dialog so that the user doesn't panic ;)

Reproducible: Always

Steps to Reproduce:
Use Adjust Time & Date dialog
Use a large set of images
press ok


Actual Results:  
No progress information

Expected Results:  
Have a progress indicator

It's particularly annoying when updating a large set of images ... it can take several minutes before the action is finished and the dialog closes ...
Comment 1 caulier.gilles 2011-12-22 22:48:18 UTC 
*** Bug 211845 has been marked as a duplicate of this bug. ***
Comment 2 Adrian Nitu 2012-03-24 11:13:35 UTC 
Created attachment 69846 [details]
Patch for the timeadjust progress bar feature

This patch adds a progress bar to the timeadjust dialog. When the button 'Ok' is pressed the progress bar shows up and displays the current progress.
Comment 3 caulier.gilles 2012-03-24 11:41:00 UTC 
Adrien,

Thanks for the patch. Please use KPProgressWidget instead QProgressBar, to post progress information to KIPI host application (digiKa support it with new Progress Manager introduced with 2.6.0)

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/common/libkipiplugins/widgets/kpprogresswidget.h

Thanks in advance

Gilles Caulier
Comment 4 caulier.gilles 2012-03-26 09:31:23 UTC 
Smit,

Another patch for TimeAdjust tool to review. Note that KPProgressWidget must be used in this patch instead QProgressBar. Look my comment #3 for details...

Gilles Caulier
Comment 5 Smit Mehta 2012-03-26 13:59:33 UTC 
Created attachment 69909 [details]
Updated patch (using kpprogresswidget)

Hi Gilles

Kindly review it. If fine, i shall commit it.

Smit
Comment 6 caulier.gilles 2012-03-26 14:08:00 UTC 
Patch is fine for me. Fell free to apply it on git/master

Gilles Caulier
Comment 7 Smit Mehta 2012-03-26 14:16:00 UTC 
Git commit 47d9c8ac9a95bfa918ace9dae51e5784e8a94d66 by smit mehta.
Committed on 26/03/2012 at 16:13.
Pushed by smitmehta into branch 'master'.

Added progress bar to show progress information when updating date on several images

M  +19   -0    timeadjust/timeadjustdialog.cpp

http://commits.kde.org/kipi-plugins/47d9c8ac9a95bfa918ace9dae51e5784e8a94d66