Bug 279184 - Compile error when build against Qt 4.8
Summary: Compile error when build against Qt 4.8
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 16:28 UTC by Radek Novacek
Modified: 2013-11-06 17:32 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.0


Attachments
Patch that fixes the build failure (636 bytes, patch)
2011-08-02 16:30 UTC, Radek Novacek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Radek Novacek 2011-08-02 16:28:40 UTC
Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

Umbrello doesn't build against Qt 4.8. There are some changes in moc in 4.8 which forbid virtual inheritance of QObject. In the case of Umbrello virtual inheritance of QObject is not needed (class OwnedCodeBlock) because any class doesn't inherit two classed derived from QObject.

Reproducible: Always

Steps to Reproduce:
Build with Qt 4.8


Expected Results:  
It should build
Comment 1 Radek Novacek 2011-08-02 16:30:29 UTC
Created attachment 62472 [details]
Patch that fixes the build failure

I'm not 100% sure that the patch is correct, but the build succeeds with it.
Comment 2 Rex Dieter 2011-08-02 16:52:46 UTC
confirm reported issue, see also related upstream report,
https://bugreports.qt.nokia.com//browse/QTBUG-19717
Comment 3 Andi Fischer 2011-08-02 20:46:01 UTC
Patch applied. Commit 1244457.
Comment 4 Sergio Martins 2011-10-30 13:32:18 UTC
(In reply to comment #3)
> Patch applied. Commit 1244457.

Can you backport to 4.7 ? Thanks.
Comment 5 Ralf Habacker 2013-11-06 17:32:30 UTC
set version-fixed-in from 4.8.0 changelog