Bug 278969 - JJ: Some wallpapers do not have a proper name in the Desktop settings
Summary: JJ: Some wallpapers do not have a proper name in the Desktop settings
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: wallpaper-image (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-07-31 20:41 UTC by Médéric Boquien
Modified: 2012-04-27 10:11 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Snapshot showing the problem (231.28 KB, image/png)
2011-07-31 20:41 UTC, Médéric Boquien 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Médéric Boquien 2011-07-31 20:41:20 UTC 
Created attachment 62399 [details]
Snapshot showing the problem

Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

In the list of wallpapers, a number of them do not have a proper name, which seems to be replaced by the size of the image in pixels.

Reproducible: Always

Steps to Reproduce:
Right-click on desktop/Desktop settings. Move to the botton on the list.

Actual Results:  
Some wallpapers do not have a proper name.

Expected Results:  
All wallpapers have a proper name.
Comment 1 Gregor Tätzner 2011-11-24 16:32:41 UTC 
yeah the metadata.desktop file is missing. I will mark this bug as a junior job.
Comment 2 Reza 2011-12-14 10:15:13 UTC 
Checked against 4.7.3 and master, every image has name.
Comment 3 Gregor Tätzner 2011-12-14 12:30:54 UTC 
No, this is not true. Did you install the additional kde wallpapers (on fedora kdeartwork-wallpapers)? Like I said in comment 1, the high-res wallpapers don't have a metadata.desktop file. see http://websvn.kde.org/trunk/KDE/kdeartwork/HighResolutionWallpapers/

Maybe plasma-wallpaper is the wrong component, though.
Comment 4 Reza 2011-12-14 13:41:38 UTC 
My mistakes.
this /usr/share/wallpapers/City_at_Night doesnot have metadata.desktop.
Comment 5 Anne-Marie Mahfouf 2011-12-17 11:33:30 UTC 
The fix consists in adding a metadata.desktop file for the mentioned wallpapers.
This is easy, the only tricky thing will be to find out who made each wallpaper to give credits in the metadata.desktop file.

This has to be committed after master reopens for 4.9 as 4.8 is in string freeze and it's not that urgent.
Comment 6 Anne-Marie Mahfouf 2011-12-20 15:02:43 UTC 
Faulty wallpapers from kdeartwork/HighResolutionWallpapers/ are:
Blue_Wood
Grass
Hanami
Media_Life (which appears twice in the Desktop Settings dialog, that might be another bug)

For example, I grepped for Blue_Wood in kde-workspace and in kdeartwork and only kdeartwork/HighResolutionWallpapers/Blue_Wood/ exists.
Comment 7 Kai Uwe Broulik 2012-04-03 19:48:40 UTC 
I for example get Horos once as "Horos by Nuno Pinheiro 1920x1080" and once as "1920x1080" name. And now with 4.8 Horos is fine but the new Ariya is shown twice in the same fashion like Horos used to.
Comment 8 Anne-Marie Mahfouf 2012-04-25 18:10:02 UTC 
It seems all fixed for me in KDE git master, leading to 4.9. Anyone to confirm?
Comment 9 Gregor Tätzner 2012-04-27 10:11:33 UTC 
I can't spot wrong labels anymore, too. Neither in KDE 4.8.2/Fedora 16 nor in KDE master. If you still got faulty wallpaper identifier please fill separate bug reports for each of them. Thanks.