Bug 278773 - crash parsing ID3v2 tag in ape file due to null pointer dereference
Summary: crash parsing ID3v2 tag in ape file due to null pointer dereference
Status: RESOLVED FIXED
Alias: None
Product: taglib
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 1.7
Platform: Arch Linux Linux
: NOR crash
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-29 11:31 UTC by Jonathan Liu
Modified: 2011-08-06 09:06 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Fix crash (577 bytes, patch)
2011-07-29 11:32 UTC, Jonathan Liu 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Liu 2011-07-29 11:31:12 UTC 
Version:           1.7 (using KDE 4.7.0) 
OS:                Linux

https://github.com/taglib/taglib/blob/master/taglib/ape/apeproperties.cpp#L140.
A null FrameFactory pointer to ID3v2::Tag constructor. Later on when reading the tag, it crashes trying to dereference the null pointer. It should omit the null pointer argument so that the default FrameFactory instance is used.

http://code.google.com/p/clementine-player/issues/detail?id=1825

Reproducible: Always

Steps to Reproduce:
Install clementine. Open APE file attached to http://code.google.com/p/clementine-player/issues/detail?id=1825.

Actual Results:  
Crash

Expected Results:  
Not crash
Comment 1 Jonathan Liu 2011-07-29 11:32:31 UTC 
Created attachment 62301 [details]
Fix crash
Comment 2 Lukáš Lalinský 2011-08-06 09:06:36 UTC 
Thank you for the patch, merged in https://github.com/taglib/taglib/commit/7cc36db7606dfc85d2e344d35c4e26fe8f698bdc