Bug 278398 - Very easy to accidentally set ones status to "Set Presence Message Here"
Summary: Very easy to accidentally set ones status to "Set Presence Message Here"
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: presence-applet (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
URL:
Keywords:
: 276381 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-07-24 16:22 UTC by David Edmundson
Modified: 2012-07-06 12:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2011-07-24 16:22:20 UTC
Version:           unspecified
OS:                Linux

I've done it, DrDanz has done it, and now gkiagia has done it. This is clearly an issue.

I suggest someone checks the applet is using the "clickText" property for this method, and not setting the actual text.

Reproducible: Didn't try

Steps to Reproduce:
N/A


Expected Results:  
Not to set your status message to "Set presence message here"
Comment 1 Francesco Nwokeka 2011-08-06 15:02:12 UTC
Git commit 0ead4ad06c83ae2100a20cc0b30d3f1b40c4c9d0 by Francesco Nwokeka.
Committed on 06/08/2011 at 17:03.
Pushed by nwokeka into branch 'master'.

FIX: default info status message is no longer set as current status message

BUG: 278398

M  +16   -2    package/contents/ui/RightPanel.qml

http://commits.kde.org/telepathy-presence-applet/0ead4ad06c83ae2100a20cc0b30d3f1b40c4c9d0
Comment 2 Rohan Garg 2011-08-06 16:55:09 UTC
I'm not so sure if its a fix or a workaround, what happens if the user is using another language? The string comparison would probably fail unless you wrap the string being compared in ki18n as well .. but i would call that as a workaround as well.
Comment 3 Rohan Garg 2011-08-17 18:18:15 UTC
*** Bug 276381 has been marked as a duplicate of this bug. ***
Comment 4 George Kiagiadakis 2011-08-17 21:03:57 UTC
Rohan is correct. This is not a proper fix. The message should at least be translated before compared, and even in this case, it's a hack. A proper fix would be to have two layers of text there, just like KLineEdit has. It's probably more of an issue that needs to be solved upstream in the QML components (i.e. there should be an equivalent to KLineEdit with all its functionality at some point)
Comment 5 Lasse Liehu 2011-08-18 05:20:45 UTC
PlasmaWidgets.LineEdit (used in EditableText.qml) is already an (kind of?) equivalent to Plasma::LineEdit and has the clickMessage property.