Bug 278345 - [2.0] Context menu > Assign Tags > Recently assigned tags not preserved between session and fixed size
Summary: [2.0] Context menu > Assign Tags > Recently assigned tags not preserved betwe...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Database-Albums (show other bugs)
Version: 2.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-23 16:55 UTC by julien.t43+kde
Modified: 2017-07-25 19:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.7.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description julien.t43+kde 2011-07-23 16:55:16 UTC
Version:           2.0.0 (using KDE 4.6.2) 
OS:                Linux

User should have the option to make recents tags menu kept between 2 sessions of digikom.
It should also be possible to have more than 10 (?) entry there if he wants to.


Reproducible: Always

Steps to Reproduce:
open digikam, assign some tag, check recently assigned tag
close digikam
re open, check recently assigned tag

Actual Results:  
empty menu

Expected Results:  
should be possible to recover same recents tags
Comment 1 caulier.gilles 2011-07-31 07:40:44 UTC
This information must be stored in DB between session.

But it's not already the case Marcel ?

Gilles Caulier
Comment 2 caulier.gilles 2011-07-31 07:41:35 UTC
Other question ? When the list must be cleared ? An action from user in contextual menu ?

Gilles Caulier
Comment 3 julien.t43+kde 2011-07-31 08:15:57 UTC
AMHA 
* resetting between session could be an option
* manually clearing menu should be available in context menu as gilles said.
Comment 4 Marcel Wiesweg 2011-07-31 13:43:56 UTC
No, it's not in the database. I would suggest to store it in the settings file.
Comment 5 julien.t43+kde 2011-11-08 08:38:22 UTC
bug still valid in 2.2.0/4.6.5
Comment 6 caulier.gilles 2011-12-15 09:14:03 UTC
Julien,

It still valid using digiKam 2.4 ?

Gilles Caulier
Comment 7 julien.t43+kde 2011-12-16 18:22:33 UTC
Hello Gilles,
sorry unable to test for now as there is no update in ppa and it seems Philipp will not provide them for ubuntu natty/11.04. I delayed my update to 11.10 because of gnome3/unity polemic and some failed upgrade reports. 

Not sure when I will be able to test.
If someone else can give feedback, I'll give mine as soon as I can but not probably before one week, so I can I have time to manage a smooth upgrade or change distribution if not happy with latest ubuntu.
Comment 8 julien.t43+kde 2012-01-06 05:02:08 UTC
NOK. tested today with digikam 2.5.0/kde 4.6.5 from Philips' PPA
Comment 9 caulier.gilles 2012-01-06 05:41:47 UTC
NOK ? Not okay for you ?
Comment 10 julien.t43+kde 2012-01-06 06:07:36 UTC
yes, not ok. not working. after tagging few pictures, restarted digikam, empty context menu.
Comment 11 Andi Clemens 2012-04-22 14:13:21 UTC
Git commit 31fb43e49ac8b938c2d41a00e0ffb065868d94c1 by Andi Clemens.
Committed on 22/04/2012 at 16:12.
Pushed by aclemens into branch 'master'.

Preserve recently assigned / used tags

This commit contains a dirty hack, because writeSettings() is called every time a tag was added / removed to an image. This is currently needed because the destructor of the AlbumDB object is never called. Setting a breakpoint in its destructor shows that it never reaches the code.

Marcel, is this a problem, besides possibly having a memory leak here?

Andi

CCMAIL:marcel.wiesweg@gmx.de

M  +33   -3    libs/database/albumdb.cpp
M  +6    -0    libs/database/albumdb.h

http://commits.kde.org/digikam/31fb43e49ac8b938c2d41a00e0ffb065868d94c1
Comment 12 Andi Clemens 2012-04-22 14:15:23 UTC
I also noticed that assigning tags doesn't work at all for me, I get the info "writing metadata" and it never closes this background task.
When I close digiKam, I need to explicitly kill the background task!
Is writing of metadata currently broken?

Andi
Comment 13 Marcel Wiesweg 2012-04-22 15:53:22 UTC
(In reply to comment #12)
> I also noticed that assigning tags doesn't work at all for me, I get the
> info "writing metadata" and it never closes this background task.
> When I close digiKam, I need to explicitly kill the background task!
> Is writing of metadata currently broken?

There is a bug report for this. I have not yet been able to reproduce the problem, it works for me
Comment 14 julien.t43+kde 2012-07-07 00:23:44 UTC
updated to 2.6.0/ubuntu ppa.
short test: start digikam, assign a tag, quit, restart, check menu
=> working. will add comments if I find it not working in coming weeks.
Thanks.