Bug 278294 - external make 's target parser should skip colons (:) in strings
Summary: external make 's target parser should skip colons (:) in strings
Status: REPORTED
Alias: None
Product: kdevelop
Classification: Applications
Component: Build tools: Custom Makefiles (other bugs)
Version First Reported In: 4.2.3
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 21:13 UTC by Boaz Harrosh
Modified: 2023-01-25 07:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boaz Harrosh 2011-07-22 21:13:43 UTC
Version:           4.2.3 (using KDE 4.6.4) 
OS:                Linux

In my external Makefile I have simple variables set like:
loo_git='git://git.open-osd.org/linux-open-osd.git'
oo_git='git://git.open-osd.org/open-osd.git'

The "loo_git='git" and "oo_git='git" are wrongly interpreted as make targets.

I guess the regular expression searches for lines that start with a none-black and contains colons (:).

But it should skip strings within 'sss' or "sss" or at least ignore such lines that contain "=" which means a variable set in Makefile, never a make target.

Thanks
Boaz


Reproducible: Always

Steps to Reproduce:
Add a string variable to a Makefile and open as a projects. Example:

foo="string with colon: makes it look like a make target"


Actual Results:  
"foo="string with colon" will be added to the Project's target list

Expected Results:  
These constructs are not make targets and should be ignored

Cheers
Comment 1 Andrew Crouthamel 2018-11-11 04:28:52 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Andrew Crouthamel 2018-11-21 04:35:35 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Justin Zobel 2023-01-10 01:52:20 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2023-01-25 05:05:24 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Boaz Harrosh 2023-01-25 07:21:04 UTC
My kdevelop about says I have 5.5.0 version.
At this version there is still the same problem.
.
I had a mistake in the description you need a string with a quote char not a double-quote string.
so 
foovar="double quote string with: within"
will be fine BUT
foovar='single quote string with: within'
Will mistake the system to think this is a make target.
That said it is such a minor bug, I would say it can just be ignored. So I am not changing the status of the bug