Bug 277040 - Incomplete Reset of Functions for Curves widget [patch]
Summary: Incomplete Reset of Functions for Curves widget [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-Curves (show other bugs)
Version: 2.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-07-04 02:08 UTC by David Vincent-Jones
Modified: 2019-03-15 20:41 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.0
Sentry Crash Report:


Attachments
Adds Popup menu with reset channel and reset all actions. (3.83 KB, patch)
2019-03-03 18:14 UTC, Sambhav Dusad
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Vincent-Jones 2011-07-04 02:08:00 UTC
Version:           0.6.2 (using KDE 4.6.2) 
OS:                Linux

Many functions have R, G, B, Alpha and Luminosity channels that can be adjusted independently. The "Reset" button should reset all of the channels and not just the visible item.

Reproducible: Always

Steps to Reproduce:
Working with an image, for instance Adjusting Curves, change any 2 channels. Now save the result and exit. When one now wishes to use the same function the normal response is to reset the visible color ... the second color remains locked as previously used.

Actual Results:  
This easily results in odd color casts being applied inadvertently to images since settings for all functions remain in place from one image to the next.

Expected Results:  
With all color functions I expect that pressing the 'reset' button will clear all channels to the neutral state.

OS: Linux (i686) release 2.6.35-30-generic-pae
Compiler: cc
Comment 1 caulier.gilles 2011-07-04 06:40:58 UTC
Do you use 0.6.2 version seriously ?

Gilles Caulier
Comment 2 David Vincent-Jones 2011-07-04 14:15:23 UTC
Version Statement Error: Should read 2.0.0-RC
Comment 3 Marcel Wiesweg 2011-07-16 14:40:57 UTC
I stumbled upon this too recently. Do we agree the behavior should be changed as described? There is no reset button then for a single curve.
Comment 4 S. Burmeister 2011-07-16 18:13:05 UTC
Just came across this today. It took me a while until I realised why clicking on "reset" would not show me the original as "after"-version. So I would agree that "reset" should reset everything.

Maybe one could add the tiny reset buttons the luminosity curve in the demosaicing tool has at its bottom-left and make that one only reset the current curve.
Comment 5 Francesco Riosa 2011-07-16 18:15:50 UTC
(In reply to comment #3)
> I stumbled upon this too recently. Do we agree the behavior should be changed
> as described? There is no reset button then for a single curve.

IMHO yes, there should be a way to reset all the curves with one click, may be
better to wait for Gilles tought

> Actual Results:  
> This easily results in odd color casts being applied inadvertently to images
> since settings for all functions remain in place from one image to the next.

meetoo ;-)
Comment 6 caulier.gilles 2011-07-17 19:33:22 UTC
look on thebottom left corner of curve widet, there is a mall button to reset curve. 

gilles caulier
Comment 7 Marcel Wiesweg 2011-07-18 17:27:31 UTC
Hm, dont see it...
There's the big button on the right, which is the point of discussion here.
The five small buttons on the left do not reset:

http://wstaw.org/m/2011/07/18/plasma-desktopX23365.jpg
Comment 8 Marcel Wiesweg 2011-08-08 20:28:44 UTC
Asking again for opinions: Anyone arguing that the Reset button should only reset the current channel, or that we need two separate Reset buttons, one only resetting the current channel, the other all channels?
Comment 9 caulier.gilles 2011-08-08 20:56:52 UTC
Marcel,

Why not to replace Reset button by a button pop-up menu with these actions : "Reset current channel" and "Reset all channels" ?

Gilles Caulier
Comment 10 Sambhav Dusad 2019-03-03 18:14:46 UTC
Created attachment 118515 [details]
Adds Popup menu with reset channel and reset all actions.
Comment 11 Maik Qualmann 2019-03-03 21:51:56 UTC
Git commit 9c43a9ebd3b7db21a683bce72552b09685a241d0 by Maik Qualmann.
Committed on 03/03/2019 at 21:50.
Pushed by mqualmann into branch 'development/dplugins'.

apply patch #118515 from Sambhav Dusad to add Popup menu with reset all action
FIXED-IN: 6.1.0

M  +29   -11   core/libs/dimg/filters/curves/curvesbox.cpp

https://commits.kde.org/digikam/9c43a9ebd3b7db21a683bce72552b09685a241d0
Comment 12 Sambhav Dusad 2019-03-15 20:41:40 UTC
*** Bug 308243 has been marked as a duplicate of this bug. ***