Bug 276970 - Does not show hours
Summary: Does not show hours
Status: RESOLVED FIXED
Alias: None
Product: knetwalk
Classification: Applications
Component: general (show other bugs)
Version: 3.0.0
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Fela Winkelmolen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-02 19:01 UTC by Frederik Schwarzer
Modified: 2022-07-21 21:37 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederik Schwarzer 2011-07-02 19:01:54 UTC
Version:           3.0.0 (using KDE 4.4.5) 
OS:                Linux

When you are really slow (I got interrupted), and a game takes more
than an hour, the displayed time - in statusbar and hgh score list -
is wrong, but score seems affected though.

This bug weas initially reported at the Debian bugtracker: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632480
by Henrik Christian Grove <debian@3001.dk>

Reproducible: Always

Steps to Reproduce:
1) Start
2) Wait


Expected Results:  
Hours should be shown.
Comment 1 Frederik Schwarzer 2011-07-02 19:51:08 UTC
This is intentional, though:

    m_gameClock = new KGameClock(this, KGameClock::MinSecOnly);

I am not sure if we should change that. The time stamp becomes unnnecessarily big then.

Opinions?
Comment 2 Stefan Majewsky 2011-07-05 10:59:39 UTC
I'd vote WONTFIX. However, in a somehow related manner, it might be a good idea to pause the game after a few minutes inactivity to remedy the IMO more realistic case of hour-long games (a window left open accidentally).
Comment 3 Peter Ped Helcmanovsky 2017-07-22 19:18:46 UTC
I would instead display "hour+" string when 3600+ seconds are detected, but this may add more problems with localization (the English "hour+" would almost fit into mm:ss space). Maybe infinity symbol would work even better (in this context to be understood as 'beyond game limits'), and normalize the value to 3600 for every such score.
Comment 4 oldherl 2022-01-13 14:56:41 UTC
This also affects kmines:
https://bugs.kde.org/show_bug.cgi?id=448364

I propose to have a "flexible" format or a "long minutes" format, so that the time string extends when it is greater than 1 hour.
```
Format              Example1   Example2
---------------------------------------
HourMinSec          00:04:05   01:02:03
MinSecOnly             04:05      02:03
FlexibleHourMinSec     04:05   01:02:03
LongMinSec             04:05      62:03
```
Using the "long minutes" format, a time period longer than 60 minutes (or even a day) could be represented, whilethe the string representation for ordinary short time periods are kept the same and easy to read.
Comment 5 Albert Astals Cid 2022-07-21 21:37:01 UTC
https://invent.kde.org/games/knetwalk/-/merge_requests/9