Bug 276798 - "Full Screen Settings" don't modify what happens when you select Full Screen
Summary: "Full Screen Settings" don't modify what happens when you select Full Screen
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
Depends on:
Reported: 2011-06-30 05:06 UTC by Kubuntiac
Modified: 2017-04-13 22:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Kubuntiac 2011-06-30 05:06:01 UTC
Version:           svn trunk
OS:                Linux

If you got to Settings -> Configure Krita -> Full Screen Settings there is a bunch of checkboxes as to what UI elements should be hidden in full screen mode. If you actually assign a shotcut to "Full screen mode" and use it, these settings have no effect. They only have an effect if you use Ctrl + H (which isn't anywhere in the gui).

Reproducible: Always

Steps to Reproduce:
1. Assign a keyboard shortcut to "Full screen mode" (say Alt+Shift + F)
2. Push it, to go into full screen mode.

Actual Results:  
No GUI elements hide.

Expected Results:  
The same result as what happens when you push Ctrl + H. (ie the selected GUI elements hide)

On a side note, having a ticked checkbox be what's HIDDEN instead of what's SHOWING is rather odd UI.
Comment 1 Halla Rempt 2011-06-30 08:01:12 UTC
Hm... Ctrl-h is shown in the "view" menu, and ctrl-shift-f (which seems to be the default shortcut for full-screen) does make krita use this feature.
Comment 2 Kubuntiac 2011-06-30 14:29:05 UTC
Ok, I think I'm getting to the bottom of this. Yes, you're right that ctrl+H is shown in the view menu. I missed it as I was looking for "Show Fullscreen" and it's listed as "Show Canvas Only". Ctrl+shift+f (which I would expect to do show fullscreen) is also bound to "Show Canvas Only".

This is confusing for a few reasons:

1. "Show canvas only" doesn't actually show only the canvas if you change any of the settings in "Full screen settings".

2. When pressing the key binding attached to "Full screen mode", it does a completely different function unrelated to the "Full screen mode" settings (it only hides the window decoration).

3. By default there is no keybinding for fullscreen mode. Only for "Show Canvas Only".

4. Show full screen settings do not alter full screen modes behaviour at all (they *do* alter "Show Canvas Only")

5. "Full Screen Mode" doesn't appear in any menu ("Show Canvas Only" does)

Suggested solution (solves *all* issues listed above):
1. Rename what is currently called "Show Canvas Only" to "Full Screen Mode" (using "Full Screen Mode" icon. Keep the ctrl+h,ctrl+shift+f keybindings and position in the View menu.)

2. Remove what is currently called "Full Screen Mode" altogether. Without a menu item or keybinding it is very undiscoverable and does nothing but hide the windeco anyway.
Comment 3 Kubuntiac 2011-07-04 18:53:47 UTC
There just seems no reason to have two fullscreen modes, especially when one is unused and the one that users, the Krita settings and even boud call "Fullscreen Mode" are called something else in the menu.

I got very confused by looking up "Fullscreen Mode" in the configure shortcuts, assigning a key binding and then finding that "Fullscreen Mode" was not affected at all by the "Fullscreen Settings" in Help -> Configure Krita. I was looking for "Fullscreen" in the Configure Shortcuts because when I looked for "Fullscreen" in the view menu, it just isn't there. (Yes, "Canvas Only Mode" is there, but everyone, boud included call it Fullscreen.)

If we had "Fullscreen" in the View menu (triggering what is now "Canvas Only Mode") we wouldn't have users (like MrBeast and I) not being able to find it and asking on IRC. It would also make "Fullscreen Settings" actually impact what was called "Fullscreen Mode" (now "Show Canvas Only Mode").

As far as I can see, it's just changing one language string, one icon, and removing the old, unused "Fullscreen Mode" (not the beautiful mode currently triggered by ctrl+h).
Comment 4 Halla Rempt 2011-07-05 07:56:53 UTC
I know, I know... I'm convinced :-). I just haven't found out a way to fix the problem -- the fullscreen action is defined deep inside the calligra libraries and I haven't figured out how to remove it completely or replace it with mine.g
Comment 5 Sven Langkamp 2011-07-08 16:53:47 UTC
Git commit d8abe22058a3a1e95933c96fdda26dd58c222e37 by Sven Langkamp.
Committed on 08/07/2011 at 18:52.
Pushed by langkamp into branch 'master'.

remove fullscreen action

M  +7    -7    krita/ui/kis_view2.cpp