Bug 275872 - KDE theme OK button missing a corner in Chrome
Summary: KDE theme OK button missing a corner in Chrome
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: KDE Artists Mailinglist
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 05:43 UTC by Robert Simmons
Modified: 2011-07-29 23:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screen capture of OK button missing a corner (26.56 KB, image/png)
2011-06-17 05:43 UTC, Robert Simmons
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Simmons 2011-06-17 05:43:05 UTC
Created attachment 61071 [details]
screen capture of OK button missing a corner

Version:           unspecified (using KDE 4.6.4) 
OS:                Linux

The OK button in the "Edit Bookmark" window is missing a corner.  I don't know if this is a Chrome problem, a KDE theme/graphics problem, or a Kubuntu graphics problem, but it has been there across a few version updates of Chrome/Chromium.

Reproducible: Always

Steps to Reproduce:
Open Chrome.
Open a webpage
Click the star at the far right of the URL box
CLick the Edit button to open the Edit Bookmark window
Look at the OK button

Actual Results:  
OK button is missing a corner

Expected Results:  
Normal OK button

See screen capture
Comment 1 Robert Simmons 2011-06-17 07:39:31 UTC
Someone mentioned that this might be the resize thingy (I don't know what to call it) being drawn on top of the button, so perhaps this bug belongs to KWin?
Comment 2 Robert Simmons 2011-06-17 07:40:07 UTC
Also, when I resize the window, the problem remains.
Comment 3 Hugo Pereira Da Costa 2011-06-27 06:19:50 UTC
I doubt this is the resize handle drawn by kwin (more precisely, by oxygen-window-decoration in kwin), since it is not drawn properly, and should only appear when there is no window decoration border. To make sure, type oxygen-settings in terminal, select "window decoration" on the left, then "fine tuning" tab, then report the value of the option named: "extra size grip display".

Also, could you post the appearance of the same dialog, using a different gtk style. 

Finally, which version of oxygen-gtk do you have, and which version of google chrome. The same dialog looks quite different here:

http://i.imgur.com/sBe9a.png

Thanks in advance,

Hugo

(PS reassigning to the relevant product, component).
Comment 4 Ruslan Kabatsayev 2011-06-27 10:16:39 UTC
First, this doesn't look like oxygen-gtk. It's QtCurve instead. Second, this corner seems to be with latest ubuntu while it hasn't been there before. It might be some ubuntu-specific gtk configuration, or a gtk plugin. It appears with any WM i tried. So, i think it's not our bug.
Comment 5 Ruslan Kabatsayev 2011-06-27 10:18:57 UTC
And, yes, it *is* a resize handle (which we draw as empty).
Comment 6 Hugo Pereira Da Costa 2011-06-27 10:34:32 UTC
yes. A resize handle *from gtk* not from kwin (was my point). 
Painted either by google-chrome itself (and overlapping with button)
or via ubuntu.

In which case it should also appear with another gtk theme. 

Which, in turn, would mean (again) that it is not our bug.
Comment 7 Ruslan Kabatsayev 2011-06-27 10:59:33 UTC
It does appear with another theme - QtCurve - as seen in the screenshot :) 
Also, it appears with ubuntu default gtk theme.

In fact, we might be able to work around this ubuntu-forced resize grip by forcing its zero size like here: http://www.omgubuntu.co.uk/2011/05/disable-the-resize-grip-in-ubuntu-11-04/
And this might even be a good addition to empty rendering of it.
Comment 8 Hugo Pereira Da Costa 2011-06-27 11:53:31 UTC
Sounds good. Will add to gtkrc.
Comment 9 Hugo Pereira Da Costa 2011-06-27 12:08:55 UTC
mmm. 
Adding 

style "oxygen-sizegrip" = "oxygen-default"
{

    # force resize-handle size to zero
    GtkWindow::resize-grip-height = 0
    GtkWindow::resize-grip-width = 0
}

class "GtkWidget" style "oxygen-sizegrip"

to gtkrc (from oxygen-gtk)
does not seem to work. (to debug I re-enabled the size grip drawing from oxygenstylewrapper, and tested on twf).

Ruslan, can you confirm/infirm ? 
What do I miss ?
Comment 10 Hugo Pereira Da Costa 2011-06-27 12:11:46 UTC
beside, 
  GtkWindow::resize-grip-height
  GtkWindow::resize-grip-width
does not seem to be documented anywhere in gtk land.
Is it ubuntu specific ?

I'll commit nonetheless but would like to have confirmation that it fixes the issue.
Comment 11 Hugo Pereira Da Costa 2011-06-27 12:14:05 UTC
Git commit c039807669a66e8bc7df5921fb11ec7533c89d75 by Hugo Pereira Da Costa.
Committed on 27/06/2011 at 14:12.
Pushed by hpereiradacosta into branch '1.1'.

Force resize-grip size to zero, following instructions from
http://www.omgubuntu.co.uk/2011/05/disable-the-resize-grip-in-ubuntu-11-04/

CCBUG: 275872

M  +10   -0    rc/gtkrc     

http://commits.kde.org/oxygen-gtk/c039807669a66e8bc7df5921fb11ec7533c89d75
Comment 12 Hugo Pereira Da Costa 2011-06-27 12:14:05 UTC
Git commit 4595a2c67ad21227fe043b7035c62000388feb86 by Hugo Pereira Da Costa.
Committed on 27/06/2011 at 14:12.
Pushed by hpereiradacosta into branch 'master'.

Force resize-grip size to zero, following instructions from
http://www.omgubuntu.co.uk/2011/05/disable-the-resize-grip-in-ubuntu-11-04/

CCBUG: 275872

M  +10   -0    rc/gtkrc     

http://commits.kde.org/oxygen-gtk/4595a2c67ad21227fe043b7035c62000388feb86
Comment 13 Ruslan Kabatsayev 2011-06-27 18:53:31 UTC
> Ruslan, can you confirm/infirm ?

I confirm that this fixes the issue on Ubuntu.

> does not seem to work. (to debug I re-enabled the size grip drawing from
> oxygenstylewrapper, and tested on twf).

> does not seem to be documented anywhere in gtk land.
> Is it ubuntu specific ?

I think yes, it looks like Ubuntu hack to make people's life harder :)

Anyway, this bug can be closed now.