Created attachment 60958 [details]
make kdevplatform build with KDEENABLEFINAL

When KDEENABLEFINAL is set, kdevplatform-1.2.0 fails to build. One of our Gentoo users experienced with that setting created a patch, which I am passing on to you here for review and integration.

From the linked Gentoo bugreport:

Erik 2011-03-27 13:59:58 CEST

Created attachment 267383 [details]
patch that fixes the build

This patch fixes errors in kdevplatform 1.2.0 so that it can be built:
* Define metatypes in header files and include them instead of having multiple
Q_DECLARE_METATYPE(TYPE) for the same TYPE (see
http://www.mail-archive.com/kde-core-devel@kde.org/msg00416.html).
* Explicit static casts where needed according to the compiler.
* Define urlToData in one place only (a separate new header file).
* Rename one of the functions appendActions to appendContextMenuActions to make
the signature unique.
* Add include guard to greputil.h
* Rename one of the structs Visitor to selfAnalysisVisitor to make the
identifier unique.
* Use a unique include guard in appendlist_static.h (not the same as in
appendlist.h)
* Undefine the macro "mix" after use to not pollute the namespace.