Version: unspecified (using KDE 4.6.2) OS: Linux SuperKaramba themes without pre-defined background do not use default Plasma widget background anymore (in comparison to 4.5.x) Please have a look at: http://forum.kde.org/viewtopic.php?f=67&t=95430 Reproducible: Always
if a patch is submitted, it will be accepted. superkaramba is in legacy support and not actively developed.
Created attachment 71795 [details] Patch to fix missing plasma background
I fixed this bug in Rosa 2012 & Mandriva Cooker. See attachment above.
what about superkaramba themes that should not have a standard background?
(In reply to comment #4) > what about superkaramba themes that should not have a standard background? Well, I didn't test any of those in "plasma widget" mode yet. It needs to be checked. But in general, I guess such themes are usually used as plain superkaramba widgets.
can you commit?
(In reply to comment #6) > can you commit? No, I guess I don't have permissions for that.
Git commit 0c3d3f3668d6867593e1c1b4429f7c6cfb950c5c by Nicolas Lécureuil. Committed on 14/03/2013 at 13:50. Pushed by nlecureuil into branch 'master'. Fix background in superkaramba theme Patch from Pulfer M +1 -0 plasma/skappletadaptor.h http://commits.kde.org/superkaramba/0c3d3f3668d6867593e1c1b4429f7c6cfb950c5c
Hi! I have to comment on this - although labeled "RESOLVED FIXED" - bug, since 1) I disagree on the implemented solution and 2) it doesn't work as it is supposed to! (I could file another bug report, but I believe for ease of following this, it's better to use this old one?) Firstly, I believe that most superkaramba themes that don't have a background enabled in the theme, were designed to be used without one. So it makes no sense (forcibly) enabling one! I have to admit, that I haven't done any statistics on the themes, it may be it varies from theme to theme, but in any case, if this is enabled, it should be an option, not forced. I have to admit, though, that I never used superkaramba until KDE 4.10, so I may be in the wrong here, since I haven't done any extensive testing on pre-KDE-4.6). But in any case, some more issues remain; (In reply to comment #5) > (In reply to comment #4) > > what about superkaramba themes that should not have a standard background? > > Well, I didn't test any of those in "plasma widget" mode yet. It needs to be > checked. I did, and they (or at least some of them) look ugly, and there's no way disabling the plasma bg with the patch! See links in the end. (In reply to comment #5) > But in general, I guess such themes are usually used as plain superkaramba > widgets. I don't understand the rationale of the above comment. Why should any theme be used as a standalone superkaramba widget? There's the plasma's own widget selector that does the exactly same job (although .skz are uninstallable from the GUI currently, but that's another issue which has it's own bug report), and does it better in some ways (with current superkaramba's standalone implementation the desktop menu is drawn below a theme, but that's also another issue; and also I would prefer my widgets / themes to be found in one place, instead of two). Also, in addition the plasma bg does not get disabled even if a theme does have a background. Here's some screenshots demonstrating the effect of the patch (sorry, each is 2MB - the theme in use is one that I modified a little bit to work better with my hardware). You can see the result here. There are three problems: 1) The plasmoid bg is not drawn in the right place (the original theme moves the bg a little bit - i.e. there's an X and Y offset); 2) the bg does not get disabled even with the bg image enabled in the theme (I tried setting the offests to 0, it makes no difference) and 3) there should be a way to disable the default plasmoid bg, since I believe, most themes that dont have one in the theme, were designed to run without one in the first place! Here's the theme kit I used to make my current theme (and then modify a little bit, since I didn't like some of the default layout, and some sensors were not working, and with my current desktop bg I like to disable the grey background - but this is suitable for a test case): <http://kde-look.org/content/show.php/Kit+System+Monitor?content=155246> Here's a link to some screenshots along with my modified .theme file: <http://www.student.oulu.fi/~villeaak/superkaramba-plasma-bg/> There are three screenshots: - screenshot first without the patch to show how the theme without a bg looks like, - screenshot with the patch, with no background in superkaramba theme; - screenshot with the patch, with the superkaramba background enabled (but plasmoid default bg still get's drawn!)
(In reply to comment #9) > I have to admit, that I haven't done > any statistics on the themes, it may be it varies from theme to theme, but > in any case, if this is enabled, it should be an option, not forced. I have > to admit, though, that I never used superkaramba until KDE 4.10, so I may be > in the wrong here, since I haven't done any extensive testing on pre-KDE-4.6). The patch only restores old pre-KDE-4.6 behaviour. > Here's some screenshots demonstrating the effect of the patch (sorry, each > is 2MB - the theme in use is one that I modified a little bit to work better > with my hardware). And another one from me: http://s42.radikal.ru/i097/1307/b6/f8f097be5661.png Making plasma background optional is a feature request. I agree that having such feature makes sense. So I may take a look how to implement it when I have time for that (as there seems to be no superkaramba maintainer in KDE upstream anymore).