Created attachment 60764 [details] test file (open with umbrello, do a codegen) Version: unspecified (using Devel) OS: Linux http://websvn.kde.org/trunk/KDE/kdesdk/umbrello/umbrello/codegenerators/sql/mysqlwriter.cpp?view=markup 160 sql<<m_endl; 161 sql<<"-- CHECK Constraints are not supported in Mysql ( as of version 5.x )"; 162 sql<<m_endl; 163 sql<<"-- But it'll parse the statements without error "; 164 165 // call base class 166 SQLWriter::printCheckConstraints( sql, constrList ); There should be a newline somewhere on lines 163/164. Else, part of line 166 output could be commented out by line 163, as it does not always begin with a newline. Reproducible: Always Steps to Reproduce: Download attached *.xmi file, open it, do a codegeneration (MySQL). Look at the end of object2.sql. Actual Results: -- CHECK Constraints are not supported in Mysql ( as of version 5.x ) -- But it'll parse the statements without error ALTER TABLE object2 ADD CONSTRAINT object2_object1 FOREIGN KEY (parent) REFERENCES object1 (id); Expected Results: -- CHECK Constraints are not supported in Mysql ( as of version 5.x ) -- But it'll parse the statements without error ALTER TABLE object2 ADD CONSTRAINT object2_object1 FOREIGN KEY (parent) REFERENCES object1 (id); This is not a good usecase, but i think that this should be fixed anyway.
Can someone please fix that? It's trivial.
Yup.
SVN commit 1296156 by okellogg: MySQLWriter::printCheckConstraints(): Write missing m_endl to QTextStream before calling base method. M +2 -0 ChangeLog M +1 -0 umbrello/codegenerators/sql/mysqlwriter.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1296156
Thanks!
apply fixed bug from 4.9.0 changelog