Bug 275156 - within the game, the highscore list appears (but the game isn't really over ;-))
Summary: within the game, the highscore list appears (but the game isn't really over ;-))
Status: RESOLVED FIXED
Alias: None
Product: klickety
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.0
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: nihui
URL:
Keywords:
: 295346 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-06-07 21:43 UTC by Jens
Modified: 2018-11-10 22:44 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot when the bug appeard (49.31 KB, image/gif)
2011-06-07 21:43 UTC, Jens
Details
Game to easily reproduce the problem. (77 bytes, application/octet-stream)
2013-10-16 10:46 UTC, Martin Walch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2011-06-07 21:43:49 UTC
Created attachment 60760 [details]
screenshot when the bug appeard

Version:           2.0 (using KDE 4.6.0) 
OS:                Linux

Within the game, the highscore list appears despite of possible moves. If i cancel the list, i can finish the game normally. (I didn't try the button "eintragen" in the highscore list). Could reproduce this only 1x after i discoverd the error, so it doesn't seems to happen frequently.

Reproducible: Sometimes

Steps to Reproduce:
Play the game once more until it happens.



I use this game under LXDE because the machine is quite old. Please find attached a screenshot.
Comment 1 Christoph Feck 2011-10-25 12:35:53 UTC
As far as I can see, this is caused by the code to check if there are still possible moves not correctly taking into account the future moves caused by animations.
Comment 2 Christoph Feck 2012-03-08 22:15:43 UTC
*** Bug 295346 has been marked as a duplicate of this bug. ***
Comment 3 Bernhard Jungk 2012-07-17 08:05:15 UTC
This bug still exists. And a similar bug in KDiamond. A simple mutex sychronizing the animations and the check for game over should solve these kinds of problems once and for all.
Comment 4 Martin Walch 2013-10-16 10:46:43 UTC
Created attachment 82877 [details]
Game to easily reproduce the problem.

Problem is still there in KDE 4.11.2.
This is a game that allows for easily reproducing the problem:

load it and then select:
- 8 red
- 2 green
- 5 green
now quickly:
- 5 blue
- 3 red
"game finished"
- 2 blue
Comment 5 Andrew Crouthamel 2018-11-10 03:13:11 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Martin Walch 2018-11-10 10:16:54 UTC
Still happens with the attached game in Klickety 2.1+ from KDE Applications 18.04.3.
Comment 7 Albert Astals Cid 2018-11-10 22:44:46 UTC
Git commit 43fe3816638acbef93de230d1140c59b24b06c4f by Albert Astals Cid.
Committed on 10/11/2018 at 22:43.
Pushed by aacid into branch 'Applications/18.12'.

Fix Game Finished being reported incorrectly

When clicking while the animation is still being run

M  +6    -1    gamescene.cpp

https://commits.kde.org/klickety/43fe3816638acbef93de230d1140c59b24b06c4f