Version: 4.5.3 (using KDE 4.5.5) OS: Linux See forum.kde.org/viewtopic.php?f=69&t=95281 for discussion. Suggestion is "to switch to event loop driven code and use KIO::Job" so that the unnecessary notifications for each price update do not occur. The notifications are irritating and mean that no other application can be used while KMM is updating prices. Reproducible: Always Steps to Reproduce: Tools->Update Stock and Currency Prices Actual Results: Each time a price updates a notification pops up that is too brief to read. Expected Results: No notification OS: Linux (i686) release 2.6.35-28-generic Compiler: cc
Git commit ce5bddee38b1170dbf2cd842c39b9a25ee5371d6 by Christian Dávid, on behalf of Artur Puzio. Committed on 03/02/2016 at 20:47. Pushed by christiand into branch 'frameworks'. Changed to asynchronous download in converter/webpricequote Using KIO::file_copy now. The code in dialogs/kequitypriceupdatedlg was ideal to code this feature. The first download is triggered by slotUpdateAllClicked. Then the next downloads are trigered by signals from WebPriceQuote. This makes the ideal possibility to create assynchronous transfers as getting back to slotUpdateAllClicked immidietly after starting the job haven't broke anything. The original review request was based on master which is qt4 based. Christian David adopted the changes to KF5 and Qt5. FIXED-IN: 5.0 CCMAIL: Artur Puzio <cytadela88@gmail.com> REVIEW: 126882 M +48 -28 kmymoney/converter/webpricequote.cpp M +2 -1 kmymoney/converter/webpricequote.h http://commits.kde.org/kmymoney/ce5bddee38b1170dbf2cd842c39b9a25ee5371d6