Steps to Reproduce:
Have album with only one track. Give this track 3,5 rating. Edit track information for the whole album.
The album has 3,0 rating.
The album has 3,5 rating.
OS: Linux (i686) release 2.6.38-9-generic
Ok, it's not entirely like this. Rounding algorithm was changed in 2.4.1. For example album with ratings:
has now rating 3,5, in all previous versions it had 4, which is mathematically more correct.
Not a regression, but a duplicate of an old bug you reported yourself :)
*** This bug has been marked as a duplicate of bug 268246 ***
That's not a duplicate. Both are my reports and both are about different
issues. The 268246 one is about incorrectly saving ratings to files, this one is about incorrectly calculating album rating.
With "album rating" you mean the rating that is displayed on the first page of the edit-track-details dialog?
Karaluh, could you please answer? Without your feedback there is not much we can do here.
Sorry, I forgot about the notification e-mail. Yes, this is the rating indeed. I was refering to it as "album rating" because it is how I use this info.
Thank you for the feedback.
Seems to work for me.
Can you check it with the latest version and try to give me a more detailed instruction how to reproduce?
Bug still present in 2.4.3. Take 8 tracks, rate 5 of them 3,5 and the rest 3. When you see the track details for all the tracks, the rating is 3, but it should be 3,5 instead.
(5 * 3,5 + 3 * 3) / 8 = 3,3125
That is displayed as 3 stars. So it's always rounding down.
Is that what you are complaining about?
Yes, that would be the problem.
In Amarok 2.5 I am getting the same results as Comment #9. Though not sure whether it is a "bug" or the way it should really be.
Setting status to confirmed.
Git commit 6014811fda5a1ea71b4576630a7b8ae2e3754e4c by Matěj Laitl.
Committed on 03/07/2012 at 18:12.
Pushed by laitl into branch 'master'.
TagDialog: correct rounding for rating
I still wonder how observant our users are. :-)
M +1 -0 ChangeLog
M +2 -1 src/dialogs/TagDialog.cpp