Created attachment 59756 [details] Argentina Holidays file Version: 4.6 (using KDE 4.6.2) OS: Linux Once again the Argentine legislation for holidays has changed. I am attaching the updated file. Please update the file, with the one included in this bug report. Reproducible: Always I am the author of the previous Argentine holidays files. (see my old bug 150203 , bug 172289 and bug 256007 )
Comment on attachment 59756 [details] Argentina Holidays file Update Argentine holiday rules file, for change in a 2011 holiday
Created attachment 59916 [details] git format-patch Patch for git to fix the reported issue
John, Could you please review my patch. Thanks
Created attachment 67492 [details] New Argentine Holidays Files Again Argentina holidays changed
Created attachment 67493 [details] git format-patch
Thanks, I'll update that tonight for 4.8. Just to clarify, the "Día de San Martín" is only supposed to happen in 2011? In which case I think it would be easier and clearer just to write the date directly as 20.08.2011?
Thanks!! It is a little tricky. "Dia de San Martin" is always 3rd Monday of august (every year), but in 2011 it was approved a law that only that year it will be on 4th Monday of august. I am doing some date arithmetic there. (year == 2011) results in 1 for 2011 and 0 otherwise. So, For year==2011 => (third + (year == 2011)) monday in august (third + (2011 == 2011)) monday in august (third + (1)) monday in august (third + 1) monday in august fourth monday in august And for any other year => (third + (year == 2011)) monday in august (third + (0)) monday in august (third + 0) monday in august third monday in august Is there another way to express this condition? Should I comment the logic used in the holidays file? Thanks again
This one has fallen off the radar? Christophe, maybe you take this one?
Git commit 1cea03b115faedf3bfc900fc6a61776f1fab63e2 by Christophe Giboudeaux, on behalf of Daniel Mario Vega. Committed on 01/02/2012 at 16:21. Pushed by cgiboudeaux into branch 'master'. Update Argentine holidays. FIXED-IN: 4.8.1 M +4 -3 kholidays/holidays/plan2/holiday_ar_es http://commits.kde.org/kdepimlibs/1cea03b115faedf3bfc900fc6a61776f1fab63e2
Git commit 1a07f7cbbeb6713277ce1dee383d22d633d1ea8c by Christophe Giboudeaux, on behalf of Daniel Mario Vega. Committed on 01/02/2012 at 16:21. Pushed by cgiboudeaux into branch 'KDE/4.8'. Update Argentine holidays. FIXED-IN: 4.8.1 (cherry picked from commit 8994337afc1ff8471148fa0227ee1750ce94b2cf) M +4 -3 kholidays/holidays/plan2/holiday_ar_es http://commits.kde.org/kdepimlibs/1a07f7cbbeb6713277ce1dee383d22d633d1ea8c