Bug 272179 - JJ: Detect system known protocols and create links for them
Summary: JJ: Detect system known protocols and create links for them
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: text-ui (show other bugs)
Version: git-latest
Platform: Unlisted Binaries Linux
: NOR minor
Target Milestone: 0.4.0
Assignee: Lasath Fernando
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 19:37 UTC by Francesco Nwokeka
Modified: 2012-07-06 12:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Nwokeka 2011-05-01 19:37:58 UTC 
Version:           git-latest (using KDE 4.6.2) 
OS:                Linux

Match: "\\b(([a-z]*)://)\\b[^ \t\n\r\f\v]+" to detect known protocol (protocols know to the system) links.
If it's a known protocol then build a URL.

lib/adium-theme-view.cpp


Reproducible: Always
Comment 1 Lasath Fernando 2011-06-25 07:31:52 UTC 
So wait, has this been fixed? 

Because AdiumThemeView::replaceMessageKeywords() seems to replace a few protocols with appropriate links. 

Is the bug that there should be more protocols in that list, or that there should be a regexp replacing ALL URI's?
Comment 2 Francesco Nwokeka 2011-06-25 07:50:17 UTC 
(In reply to comment #1)
> So wait, has this been fixed? 
No, not yet

> Because AdiumThemeView::replaceMessageKeywords() seems to replace a few
> protocols with appropriate links. 
> 
> Is the bug that there should be more protocols in that list, or that there
> should be a regexp replacing ALL URI's?
there should be more in that list. Preciseley the protocols known to the system that you can get from : KProtocolInfo::protocols() was my idea.
Comment 3 Lasath Fernando 2011-06-25 14:45:56 UTC 
Okay. I fiddled around with QRegExp a bit, and I think I got the hang of it. I'll fix this tomorrow, as I'm wayyyy too sleepy right now.

PS: How do I actually 'assign' a bug to myself?
Comment 4 Martin Klapetek 2011-06-27 08:41:58 UTC 
(In reply to comment #3)
> PS: How do I actually 'assign' a bug to myself?

I think you have to have the right rights ;) I'm assigning it to you.