Bug 271315 - GUI improvement for manual geotagging
Summary: GUI improvement for manual geotagging
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-GeolocationEdit (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-19 20:52 UTC by Milan Knížek
Modified: 2016-07-18 04:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Knížek 2011-04-19 20:52:07 UTC
Version:           2.0.0 (using KDE 4.6.2) 
OS:                Linux

A workflow for geotagging images manually can be:
1. select images in album view, which were taken on (or showing) the same location
2. open menu Image / Geolocation
3. go to Search tab and type in the location name
4. you get some possible locations/addresses as an answer

Now, the troubles come on the following steps:

Problem A: the map shows the returned addresses as "A", "B", ... marks. However, there is no way how to easily zoom in on the map to e.g. the proposed location "A". (Use of + button is very slow.)

Problem B: once you manually zoom in to see some more details about location "A", you can choose another position (say few hundred meters away from the marked location "A") by a left-click on the map, choose "copy coordinates" from the second level of pop-up menu, then select images in the bottom part of the window, right-click and choose "paste" from the pop-up menu. This is slow.


Reproducible: Always



Expected Results:  
Possible solutions:

Problem A: double-click on location "A" from the returned addresses in the search tab should automatically reload the map zoomed at the location (say 1:50 000?)

Problem B: when you long-click somewhere on the map, a new location mark (let's call it "X") should appear. Then, you could drag & drop this location mark from the map over to the images and the selected images should be assigned this GPS coordinates. As default, all images listed in the geolocation plugin should be preselected (when you have had selected the images in album view, then you probably wanted to work with them).
Alternatively, a left-click on the map could have a new item in the pop-up menu "Add GPS coordinates to selected images".
Comment 1 Michael G. Hansen 2011-04-21 23:08:41 UTC
Hi Milan,

thanks for your comments!

Problem A: I will look into this. Does zooming with the mouse wheel not work for you?

Problem B: Do you know that you can also drag-and-drop the selected images onto the map? The problem with context menus is that I am not sure yet how to properly implement them for the Google Maps backend, which is rendered by KHTML. But you are right, the behavior of the old "Edit coordinates" dialog, where you could simply click a point to assign the coordinates to the images is missing. Maybe we can add a "Pick coordinates" button, where the next click after the button on the map causes the clicked coordinates to be assigned to the images. This would work without a context menu.

Michael
Comment 2 Michael G. Hansen 2011-04-22 00:26:05 UTC
About the zooming: I don't know an easy way to determine a sane zoom level, as it depends on what you are doing. If you search for a city which exists more than once (Berlin, for example), you may first want to know which is the one in the right country, then which is the right one in the country, and then since many cities appear a few times in roughly the same location, which dot best represents the city. So we are already at three different levels here, and I think the same would be true for streets.

At least we should make it possible to select several search results, and have the map adjust the viewport such that the selected search results cover the map. When only one result is selected, leave the zoom unchanged but adjust the center.

About easier zoom adjustment: Maybe create a slider as a drop-down for the zoom buttons, much like the "Scale" float item in Google Maps, to quickly adjust the zoom.

Michael
Comment 3 Milan Knížek 2011-04-22 11:09:19 UTC
Hi Michael,
zooming by mouse-scrolling works, but it really takes time to zoom in to a reasonable detail.

You are right about the need to visually check if the search result is the one I am actually looking for.
Nonetheless, the geo-location first starts with a globe view and a single click on a search result centres the point mark on the map - it should be sufficient to choose the country.
Then, double-click on the search result could force the map to be zoomed to a predefined ratio (user definable in options?).
Alternatively, the right-click on the search result could offer various zoom levels (I am not sure if these be defined as "1:50 000" or rather "2 km")

The same functionality (double-click, predefined zoom levels for right-click) should be added not only to the search results, but also to the image list.

The possibility to choose more search resutls and have the mapped zoomed to cover all the selected locations would be also great.

Re. the zoom in/out scale bar like in google maps is not so bad, but it is really faster to get quickly to a detailed level (dragging by mouse is error-prone, especially on notebooks).
Comment 4 Milan Knížek 2011-04-22 11:57:29 UTC
Re. Problem B:

thanks for the hint re. dragging images over the map and dropping in the wanted location, it works also with google maps and it is actually very good and would be enough for me.

How about providing some hint to the user? (Pop-up info? Text overlaid in the map corner?)

The only trouble is that when used with Google Maps, the marker with image position does not appear on the map. Interestingly, the bookmarked positions appear fine. (On OSM, all markers appear fine.)

P.S. If you want to implement what you have proposed re. the next click action on the marker/map to have the location assigned to selected images, it would improve the usability, too.
Comment 5 Michael G. Hansen 2011-04-22 15:56:53 UTC
(In reply to comment #4)
> The only trouble is that when used with Google Maps, the marker with image
> position does not appear on the map. Interestingly, the bookmarked positions
> appear fine. (On OSM, all markers appear fine.)

There was a change in the Google Maps API, and you have to use the current git version for it to work again...

Michael
Comment 6 Milan Knížek 2011-04-22 16:33:39 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > The only trouble is that when used with Google Maps, the marker with image
> > position does not appear on the map. Interestingly, the bookmarked positions
> > appear fine. (On OSM, all markers appear fine.)
> 
> There was a change in the Google Maps API, and you have to use the current git
> version for it to work again...
Works now after rebuilding. Thanks.
Milan
Comment 7 caulier.gilles 2011-12-22 13:20:13 UTC
Milan,

This file still valid using kipi-plugins 2.4 ?

Gilles Caulier
Comment 8 Milan Knížek 2011-12-23 10:46:23 UTC
Gilles,

the zoom ratio of the displayed map after clicking on a search result is okay for me now (problem A).

Closing the wish now.