Bug 271111 - Amarok does not allow several albums with same title and artist
Summary: Amarok does not allow several albums with same title and artist
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Collection Browser (show other bugs)
Version: 2.4.1
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: 2.4.1
Assignee: Amarok Developers
URL:
Keywords: investigated, triaged
Depends on:
Blocks:
 
Reported: 2011-04-16 17:36 UTC by Nikita Krupenko
Modified: 2018-09-19 14:30 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Krupenko 2011-04-16 17:36:25 UTC
Version:           2.4.0.90 (using KDE 4.4.5) 
OS:                Linux

If collection has different albums with the same name, they apperas in collection as single album. For example, in Various Artists I've got album "A Night at the Opera" with tracks from corresponding albums from Queen and Blind Guardian. Using "Do not show under Various Artists" option from context menu can fix that, but this should be correct from the beginning. Also, when I've got two albums with the same name from one artist (for examle, album and single), there is no way to split them.
IIRC, this first appeared in version 2.4

Reproducible: Always

Steps to Reproduce:
Add to collection two albums with the same name

Actual Results:  
Single album for all tracks

Expected Results:  
Multiple albums
Comment 1 Myriam Schweingruber 2011-04-17 18:19:51 UTC
Well, how about not setting these albums into Various Artists?

If you have two albums with the same name by the same artist you should add another distinction, most of the time it is a different year.
Comment 2 Nikita Krupenko 2011-04-18 09:30:37 UTC
These albums sets into Various Artists automatically.

And they has different years in both cases.

AFAIK, collection scanner was rewritten in version 2.4, so may be year just not taken into account in this case.
Comment 3 Myriam Schweingruber 2011-04-19 14:44:48 UTC
Do you have years selected to be shown in the Collection Browser?
Comment 4 Nikita Krupenko 2011-04-19 14:48:01 UTC
Yes
Comment 5 Myriam Schweingruber 2011-04-20 11:07:01 UTC
Thank you for the feedback.

BTW, you should upgrade your KDE version, current is KDE 4.6.2, 4.4.5 is rather old.
Comment 6 Nikita Krupenko 2011-05-09 22:38:46 UTC
Version 2.4.1, still not fixed.
Comment 7 blueduck 2011-05-13 21:36:21 UTC
I confirm this bug. Songs correctly tagged with different artist's names, but same album's name (like 'Greatest hits'), appear merged in a same album under Various artists.
Comment 8 Nikita Krupenko 2011-05-13 22:28:36 UTC
They should be merged, if they from one album.
Comment 9 blueduck 2011-05-14 00:05:34 UTC
Even if they're by different artists!?
Comment 10 Nikita Krupenko 2011-05-14 12:52:55 UTC
Yes, but only if it's the same album, for example, compilation. Various Artists exactly for this case. This is by default. But you can right-click on this album and select "Album->Do not show under Various Artists" for every album, you don't want to be here.

The problem in this report is about _every_ albums with the same name are treated as one album, this is not right.
Comment 11 Silver Salonen 2011-05-30 10:30:58 UTC
I have also seen it and to my mind in my case the albums had different years in their tags, but they still were shown as one album under Various Artists.
Comment 12 Ralf Engels 2011-06-01 18:54:21 UTC
Amarok will treat tracks from different directories but same album tag as belonging to one album.
Example following directory structure:

Soundtrack
   Sucker Punch
     Alison Mosshart
     Björk
     Emiliana Torrini

You see, splitting this album up into three is not really a good idea.
However, if there would have been an album artist... like "Queen", or "Blind Guardian", in such a case it would be clear for Amarok that those are really two different Albums.

So, just set the album artist and everything will be all right.
Comment 13 Nikita Krupenko 2011-06-01 19:53:51 UTC
Sorry, but I can't agree with you.
1. Albums with DIFFERENT years SHOULD NOT be treated as single album. It's clear, that if albums has different years they are DIFFERENT albums.
2. There is another problem. There can be DIFFERENT albums from single artist. For example, one can be album and another can be a single or demo. They also DIFFERENT. The simplest way to do this is to distinct albums by folders.
Comment 14 Myriam Schweingruber 2011-06-02 12:19:42 UTC
I totally agree with Nikita on this one, a different year should distinguish the album as a different one. And it always did so before, so this is clearly a regression.
Comment 15 blueduck 2011-06-05 19:40:45 UTC
I agree too with Nikita and Myriam.
Comment 16 Ralf Engels 2011-06-28 18:11:10 UTC
Sorry, have to disagree.

The year was never included as a primary key for an album.
The reason is that an "album" doesn't even store a year. The year will be taken from the first included track.

Let's change the title and status.

I would like to go a step further. Let's change Amarok in a way so that one can have several different albums with exactly the same tags.
Comment 17 Nikita Krupenko 2011-06-28 18:59:35 UTC
The title seems more correct. But the status - wishlist means, that this is not a bug. Are you thinking, that current Amarok behavior is correct?

> The year was never included as a primary key for an album.
> The reason is that an "album" doesn't even store a year. The year will be taken
> from the first included track.

You mean, that serious changes required of how to store/process collection database?
Comment 18 Myriam Schweingruber 2011-06-29 08:27:05 UTC
Nikita, features not implemented are not bugs so this really belongs to the wishlist.
Comment 19 Nikita Krupenko 2011-06-29 08:37:21 UTC
(In reply to comment #18)
> Nikita, features not implemented are not bugs so this really belongs to the
> wishlist.

So you think, that Amarok should huddle all tracks to one album and it is correct behavior?
Comment 20 Ralf Engels 2011-06-29 09:29:06 UTC
The current Amarok implementation is using a primary key for albums.

For people who didn't study computer science, a primary key is an unique identifier to access something. Like your social security number. If ever two people get the same number, nobody could tell them apart. You would be unable to correctly file your tax returns. 

Now the Amarok album primary key is composed of the album artist (which can be empty in case of a compilation) and the album title.

Amarok is unable to handle different albums that have the same title and artist. Also there cannot be two compilations with the same name. So a "Best of" better is from one artist.

It has been this way when I started hacking for Amarok two years ago and this mechanism is used in several places.

So, it's not a bug. It's just the way Amarok is designed.
I am voting for a re-design of this mechanism.
Comment 21 Nikita Krupenko 2011-06-29 09:51:52 UTC
I think, that using just album name as a unique key is like using just a name, instead of social security number. Using album and artist is like using full name. Can there be more than one people with the same name? Sure, can. Even with the same name and surname can be more than one people. So, I think, that instead of just album name, in Amarok can be used some ID, generated from album metadata (album name, album artist, year, DISCID, location on disc, etc) - some analog to this social security number.
Comment 22 Orion Poplawski 2014-08-12 19:54:05 UTC
I think I'm seeing this on Amarok 2.8.0 w/ KDE 4.13.3.  All of my albums titled "Greated Hits" are showing up all mashed together under "Various Artists" -> "Greatest Hits".  The tracks have an artist ID.
Comment 23 Myriam Schweingruber 2014-08-12 23:10:15 UTC
You think or you are sure you see it?

I have nothing mangled here, using Amarok v2.8.0-354-g4b3eaac

All albums by one band are correctly stored under the band name, those with various artist under Various where they belong.

Mind you, if one greatest Hits album only features one artist, then it should have the album artist tag set to the artist name as well.
Comment 24 Andrew Crouthamel 2018-09-19 14:30:20 UTC
This bug has had its resolution changed, but accidentally has been left in NEEDSINFO status. I am thus closing this bug and setting the status as RESOLVED to reflect the resolution change.