Bug 270666 - Problems with Removing non-jabber contacts
Summary: Problems with Removing non-jabber contacts
Status: RESOLVED WORKSFORME
Alias: None
Product: telepathy
Classification: Unmaintained
Component: contactlist (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 12:09 UTC by George Goldberg
Modified: 2012-07-06 12:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description George Goldberg 2011-04-11 12:09:59 UTC
Nwoki reports that there are some problems with removing contacts failing when trying to remove a non-Jabber contact. This needs investigating and either reporting upstream if it is their bug, or fixing if it is our bug.

Assigned to nwoki at 10th April IRC Meeting.
Comment 1 David Edmundson 2011-04-27 14:59:00 UTC
Just adding some comments from a discussion in IRC a while back.

The problem could be that ContactManager::allKnownContacts() doesn't only return items in the buddy list. It returns everyone you've got some record on the server with. 

For the buddy list we only want to show contacts for whom we have a presenceSubscriptionState. 

This could be done either in the model itself (ask boiko first) or simply as a fixed part of our filter model.

There is a talk of this being really easy to do in future telepathy with something like AccountSet but for Contacts. 

Based on that, I would choose the add it to our filter model option as it's a much faster/easier as a temporary hack.
Comment 2 David Edmundson 2011-04-28 20:49:32 UTC
Just tested this in butterfly (0.5.15)

Even after calling contactManager->removeContact(someContact);
someContact.subscriptionState still returns PresenceStateYes;

Therefore the proposed fix above will do nothing.
Comment 3 David Edmundson 2011-05-05 22:00:24 UTC
Just tried in Empathy.

Removed a contact from MSN with no problems/errors/issues at all.

This contact was also immediately removed from my KDE list.

This shows:
KDE Telepathy Contact List code that displays users works fine.
Telepathy-Butterfly works fine.

The implication is that telepathy-Qt4 behaves differently to whatever "removing" code empathy does.
Comment 4 David Edmundson 2011-05-16 18:33:10 UTC
Assigning to me for investigation.
Removing from the list of blocking bugs on telepathy release.
Comment 5 David Edmundson 2011-12-09 17:24:36 UTC
Just tested on my MSN account in Haze and everything worked fine.

This was probably a butterfly bug and therefore no longer relevant.