Bug 270649 - Bad use of arguments for translation
Summary: Bad use of arguments for translation
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-i18n (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 09:29 UTC by Marek Laane
Modified: 2017-08-12 16:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Laane 2011-04-11 09:29:19 UTC
Version:           unspecified
OS:                Linux

Metadataedit.cpp includes such code:

 setCaption(QString("%1 (%2/%3) - %4 %5 %6 ")
        .arg((*d->currItem).fileName())
        .arg(d->urls.indexOf(*(d->currItem))+1)
        .arg(d->urls.count())
        .arg(i18n("Edit"))
        .arg(tabName)
        .arg(i18n("Metadata")));

which makes almost possible to translate "Edit" and "Metadata" because in other languages than English the required word sequence may be different. Please consider making translatable all the sentence (i.e. %1 (%2/%3) - %4 %5 %6 ) ot only parts of it.

Reproducible: Didn't try
Comment 1 caulier.gilles 2011-04-11 09:36:58 UTC
Source code have been changed in-deep recently in this plugin. This i18n puzzle have been removed do of big changes in GUI.

Please update translations files...

Gilles Caulier
Comment 2 Marek Laane 2011-04-11 09:42:27 UTC
Translation file is most recent, just an hour ago updated (and http://quickgit.kde.org/index.php?p=kipi-plugins.git&a=blob&h=3a467f28f1e4b4fcac6dd222c322047ef5a35d0f&hb=627c7bccd6e96037675d9aae006de309c68bcc44&f=metadataedit/plugin/metadataedit.cpp still includes the forementioned code) but maybe it would need just another round of scripty to make your changes into translation files. Anyway, if the new code doesn't includes such word puzzle, it's great!
Comment 3 caulier.gilles 2011-04-11 09:44:43 UTC
Ah right... i don't see the last method on the bottom. In fact, this one is not necessary now (:=))). I will fix it...

Gilles Caulier
Comment 4 caulier.gilles 2011-04-11 09:53:10 UTC
Git commit 1179d66a92a68ccfccdf63a750b5bac31d9bd17a by Gilles Caulier.
Committed on 11/04/2011 at 09:58.
Pushed by cgilles into branch 'master'.

Remove i18n puzzle in dialog title.
BUGS: 270649

M  +4    -31   metadataedit/plugin/metadataedit.cpp     
M  +0    -1    metadataedit/plugin/metadataedit.h     

http://commits.kde.org/kipi-plugins/1179d66a92a68ccfccdf63a750b5bac31d9bd17a