Bug 269987 - Rename inline: in list and details views, up and down arrow keys should commit the name change and change the current item
Summary: Rename inline: in list and details views, up and down arrow keys should commi...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: general (show other bugs)
Version: 16.12.2
Platform: Fedora RPMs Linux
: HI wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
Depends on:
Blocks: extramile
  Show dependency treegraph
 
Reported: 2011-04-03 10:05 UTC by Niels
Modified: 2021-04-19 05:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 21.08
Sentry Crash Report:
shafff: Usability+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niels 2011-04-03 10:05:48 UTC
Version:           4.6.0 (using KDE 4.6.1) 
OS:                Linux

When I rename a file, I used to be able to use the up and down key to commit the name change and move to the next or previous file. This doesn't work anymore, I now have to press enter first.

Reproducible: Always
Comment 1 Frank Reininghaus 2011-04-03 10:40:10 UTC
Thanks for the report. I assume you use the "Rename Inline" mode for renaming?

(In reply to comment #0)
> When I rename a file, I used to be able to use the up and down key to commit
> the name change and move to the next or previous file. This doesn't work
> anymore, I now have to press enter first.

In which KDE version were you able to do that? In KDE 4.4.4. (which I've just tried), Up and Down don't have any effect when renaming files.
Comment 2 Niels 2011-04-03 11:28:48 UTC
Yes, inline renaming.

The up/down thing works in 3.5.10.
Comment 3 Frank Reininghaus 2011-04-03 12:58:03 UTC
Thanks for the clarification. I'll reassign to Dolphin because Konqueror uses Dolphin's code for file management in KDE 4.
Comment 4 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:19:46 UTC
Resetting assignee to default as per bug #305719
Comment 5 Nick Shaforostoff 2012-09-17 12:33:12 UTC
what is more annoying, up and down arrow keys stop working at all after i commit inline file renaming with enter!
Comment 6 Frank Reininghaus 2012-09-17 12:42:54 UTC
(In reply to comment #5)
> what is more annoying, up and down arrow keys stop working at all after i
> commit inline file renaming with enter!

This is off-topic here, and looks like bug 301252. If you can still reproduce this in KDE 4.9.1 or later, please open a new bug report. Thanks!
Comment 7 Nate Graham 2017-08-18 16:52:26 UTC
I don't think this makes sense given that file names in icon view can be multi-line, and the up and down arrow keys can be used for navigation. This could only ever make sense in list or details view, where there is no concept of a multi-line file name.
Comment 8 Nate Graham 2019-11-12 20:15:03 UTC
There is a patch that would implement this: https://phabricator.kde.org/D20427
Comment 9 Bug Janitor Service 2021-04-08 06:16:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/193
Comment 10 Méven Car 2021-04-19 05:10:32 UTC
Git commit 5a0da4a9c8d10dc1921077d84bdabf05d20150b0 by Méven Car.
Committed on 19/04/2021 at 05:10.
Pushed by meven into branch 'master'.

When renaming files, move to next file using tab key or up/down

To rename previous file:
 Up or Shift-Tab

To rename next file:
 Down or Tab

Credit goes to msciubidlo
Related: bug 403931, bug 334533
FIXED-IN: 21.08

M  +5    -0    src/kitemviews/kitemlistcontainer.cpp
M  +5    -2    src/kitemviews/kitemlistview.cpp
M  +6    -0    src/kitemviews/kitemlistview.h
M  +1    -0    src/kitemviews/kstandarditemlistwidget.cpp
M  +24   -2    src/kitemviews/private/kitemlistroleeditor.cpp
M  +18   -2    src/kitemviews/private/kitemlistroleeditor.h
M  +3    -0    src/kitemviews/private/kitemlistsmoothscroller.cpp
M  +5    -0    src/kitemviews/private/kitemlistsmoothscroller.h
M  +28   -9    src/views/dolphinview.cpp

https://invent.kde.org/system/dolphin/commit/5a0da4a9c8d10dc1921077d84bdabf05d20150b0