Bug 268641 - Inconsistent handling of 'show selection marker' for 'folder view for desktop' and 'dolphin as filemanager'
Summary: Inconsistent handling of 'show selection marker' for 'folder view for deskto...
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-folderview (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 11:43 UTC by Thomas Haenig
Modified: 2012-03-27 09:46 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Haenig 2011-03-16 11:43:56 UTC
Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

In general settings of dolphin I am able to uncheck 'show selection marker' which disables the display and function of these. But unfortunately not for the folder view of the plasma desktop. 

On the other hand when changing 'navigation' => 'Mouse' from single click to double click or vice versa the folder view is behaving accordingly. This setting changes even the respective KDE(?) system setting:

# systemsetting => Hardware => Input Devices => Mouse => Icons => single/double click


Reproducible: Always

Steps to Reproduce:
check/uncheck 'show selection marker' in dolphins general settings
- hover mouse over desktop icons (folder view)
- hover mouse over icons in dolphin


Actual Results:  
plus sign for icons in dolphin respects setting
plus sign for desktop icons (in folder view) is not influenced


Expected Results:  
plus sign should disappear for desktop icons (in folder view) too
Comment 1 Peter Penz 2011-03-16 11:52:42 UTC
The 'show selection marker' settings is Dolphin-specific currently. It would require the folder-view from Plasma and Dolphin to share a common setting in this case. I've now assigned this to the folder-view applet (minor changes in Dolphin would be required too but I'd be fine doing them if the folder-view maintainers agree to share this setting).
Comment 2 Thomas Haenig 2011-03-16 12:01:02 UTC
So wouldn't it be good to have some 'folder view specific settings' where one could easily have another setting related to single/double click?

For a file manager single click is a bit contra productive but for the desktop I am used to it and did not want to miss it.
Comment 3 Ignat Semenov 2012-01-13 16:55:18 UTC
Fixed with https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/f5eb9ffa53fc96bb1d7b68db304f1ca3816cae6c

Now the selection marker is hidden automatically if KDE is globally set to use double click, and enabled if KDE is set to use single click.
Comment 4 Thomas Haenig 2012-01-16 07:57:01 UTC
sorry, if I was not able to make my intention clear.

I was not asking for some kind of coupling between 'count of clicks' and 'marker behaviour' but for a possibility to really control the marker's behaviour (because I don't want/need them). Especially for single click they are a hindrance. 

It requires much less effort to hit 'somewhere inside the icon' than to hit 'only three quarters right and bottom of the icon because otherwise there is some hidden feature and one does not get what one tries to', so please reopen ...
Comment 5 Ignat Semenov 2012-02-03 15:58:16 UTC
"It requires much less effort to hit 'somewhere inside the icon' than to hit
'only three quarters right and bottom of the icon because otherwise there is
some hidden feature and one does not get what one tries to', so please reopen"

You can easily select an icon by holding Ctrl and clicking the icon regardless of the selection marker being enabled or disabled. So I'm closing the bug as fixed once again.
Comment 6 Thomas Haenig 2012-02-06 07:07:01 UTC
One can of course (and this is neither new for me nor for a desktop environment) hold <Ctrl> and click an icon to select a group of icons.

But what one cannot is simply (single or double) click (an arbitrary area) of an icon for starting up an application. "Oooops, hit that special area again ..."

So what is done here in my opinion, is trading one advantage (no need to use the keyboard for selections) against another (fast access to a shortcut for starting applications without too much attention). 

But maybe I am simply not young enough to take fancy in this.
Comment 7 hikaricore 2012-02-19 23:47:25 UTC
Ya know, years ago I stopped using gnome.  You know why?  The gnome devs took it upon themselves to decide that their userbase didn't need certain functionality and if they felt something shouldn't be changeable it wasn't.  Kde should be different than this and at the very least allow the option..  I've been irritated by this bug for a couple years now and I honestly figured if I waited long enough it would be fixed.  Trust me it's not.  My folder view is setup in such a way that my icons are quite small, about 3 notches from the small setting in the configuration.  Because of this clicking in the very center of the icon does nothing... nothing at all.  Why?  Because of the damn selection marker's overbearing hotspot.  My folder view is mostly useless as is and the only way I can actually launch applications using it is by clicking in a microscopically tiny area on the bottom right of the icon.  Half the time it doesn't even register there.  Please for the love of all that is unholy and evil allow us the option to disable these.  I don't want to change my click configuration to double click because hell this isn't gnome and I shouldn't have to.  Thanks.
Comment 8 Ignat Semenov 2012-02-20 08:31:57 UTC
Oh yes, indeed. I've found this out recently, too. The icon can not be clicked if the size is small enough and the marker is on. This is a bit different problem though than the simple "an option to turn it off". Thank you for identifying the real problem hikaricore. We'll think what can be done here, probably make it dependent on the size or even disabling it when the icon is small enough.
Comment 9 Thomas Haenig 2012-02-20 09:01:41 UTC
Would it to much to ask then for some kind of alert/hint or (I would hope so) a button/checkbox allowing to enable/disable the marker whose functionaltity depends on the size of the icon? 

I would think, that if a user is not aware of a connection between icon size and availability of the marker there would be some (more) confusion. 


SCNR, but
"every feature is a bug unless it can be disabled"

Regards
Comment 10 hikaricore 2012-02-20 16:03:22 UTC
I have to once again agree with Thomas, an option to simply disable this "feature" would solve all subsequent issues.  It is already able to be disabled in dolphin yet it persists in a standard plasmoid such as folder view.  Honestly the premise of the original bug is correct and needs to be addressed.  Why are you so hellbent on only making random arbitrary exceptions based on sizing and clicks when a very simple solution has already been brought up?  I'll mention this yet again, we aren't Gnome users.
Comment 11 Ignat Semenov 2012-03-03 13:46:07 UTC
OK I'm reopening this just for the record. There is indeed an issue where the overlay buttons block the icon if the icon size is <= 22px. Thank you for reporting.
Comment 12 Ignat Semenov 2012-03-27 07:00:50 UTC
ID: 141734215130c06073fc831c288f2ad6e3871645
Added by Ignat Semenov 9 minutes ago

automatically disable action buttons if they cover the actual icon

REVIEW:104413
Comment 13 Thomas Haenig 2012-03-27 07:25:23 UTC
Of course it is up to you, wether you listen to wishes or arguments or not as you are the one having to implement them. 

But it is one more argument to keep me using what I have - KDE3 - until maybe XFCE/LXDE aquires some more of the older KDE's comfort without the newer's bloat.
Comment 14 hikaricore 2012-03-27 07:32:38 UTC
So just to confirm, you'll fix something if it's causing an actual problem, but refuse to do so if it's something which is only cosmetic?  While I appreciate that my issue has been fixed, the original bug report is still unresolved and for whatever reason is being ignored.  Is there any way we can get this assigned to someone less stubborn?
Comment 15 Ignat Semenov 2012-03-27 09:10:22 UTC
OK guys, just to make it clear. I am not being "stubborn" here. I have discussed this issue with Aaron Seigo and he said that the option to disable the "+" button is not welcome for some reason. Please, take into account that even though KDE is an Open Source project, any code has to go through the review process, and in this case, the option to disable the "+" button got rejected by the project leader.

Now, coming back to the original issue, what did we (the plasma team) do? First, we tied the seleciton marker to the mouse single / double click setting. This is completely rational in my opinion, as with d-click, you don not actually need a selection marker, you can just click the icon once and it is selected. Second, we fixed a pretty serious usability issue by making sure the action buttons never occlude the actual icon, which is something you also want to happen unconditionally. In my opinion, it is ok if the system prevents you from having to disable it on auto every time you switch to an icon size small enough for the buttons to pose a problem.

So now the only usecase left is when you use KDE in single-click mode and the icons are big enough for the selecion marker to appear. In this case, you might really want to disable the marker. However, since it is guaranteed not to occlude the icon, it does not pose any usability problems at all. (see https://bugs.kde.org/show_bug.cgi?id=268641#c6) So in this case, it is a wish, not a bug, and this wish has been relected by Aaron Seigo, the Plasma project leader.

Fell free to come to #plasma on irc.freenode.net and ping aseigo for details.
Comment 16 Marco Martin 2012-03-27 09:30:26 UTC
that's at most a problem in dolphin.
that + has been made for making easy to select files when single click is enabled.

the design of the UI is such that is quite difficult to work without it with single click and is quite useless with double click. therefore is enabled/disabled in those cases.

adding an option there, and worse adding an option completely independent from dolphin (and here is where i don't really understand why dolphin has it) helps only to make things inconsistent, UI less predictable and code harder to maintain with necessary quality.

so yes, I'm sorry but we cannot have this, for the mentioned reasons.
Comment 17 Thomas Haenig 2012-03-27 09:31:30 UTC
I am sorry if this sucks, but if my case would't be the "only usecase left" I wouldt't bother onyone.

And in my opinion it "occludes the icon" very well as not the whole icon triggers the desired action. Assuming, my icons are 23px by 23px (1px more than the mentioned magical limit) so I have 2 stripes of the icon each 1px wide and 23px long to hit.

That looks like a good opportunity to improve ones skills related to headshots in shooters. 

Whatever the reason it does no longer matter for me, I am done.
Thanks for your time.
Comment 18 Thomas Haenig 2012-03-27 09:35:34 UTC
sorry again, it has already been "easy to select files when single click is enabled" - one could simply drag a frame around and for more use <Strg> without clicking the icon itself directly. NO problem here.
Comment 19 Ignat Semenov 2012-03-27 09:40:40 UTC
Well the limit is not hardcoded. The limit is decided based on the icon size, the action button size and the sv frame size. Set the icon size to 2 slider clicks from the left with the Air theme, the marker will be there. Now switch to Oxygen and see the marker disappear :)
Comment 20 Thomas Haenig 2012-03-27 09:46:21 UTC
from Comment #16: adding an option ... would make UI less predictable and code harder to maintain

so what should I conclude from Comment #19?

"Whatever, ... the mess bets messier!"?