Bug 268622 - Highlight own nick option should watch for all nicks configured in the relevant Identity
Summary: Highlight own nick option should watch for all nicks configured in the releva...
Status: CONFIRMED
Alias: None
Product: konversation
Classification: Applications
Component: notifications (show other bugs)
Version: 1.3.1
Platform: unspecified All
: NOR wishlist
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-16 04:35 UTC by Alexandru Stan
Modified: 2013-04-15 02:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Stan 2011-03-16 04:35:15 UTC
Scenario:
* I have amstan_ as my nick
* Someone says "amstan"
* I don't get highlighted

Suggestion:
* Highlight own nick should highlight all nicks for the current identity.
* For cases where nick is not in current identity, the current nick should be cleared of trailing underscores before matching with the line.
Comment 1 Matija Šuklje 2011-05-09 11:50:53 UTC
I agree with this issue.

Since sometimes even on IRC (dunno why) people call me by my real name, I would rather suggest that the user could just add custom strings that they would like to be associated with them (e.g. Matija, Šuklje, hook, silver_hook, "Hey! Lazy arse!") and a checkbox whether it should be case sensitive or not.

As a work around I am currently (ab)using word highlight, which is not an ideal solution.
Comment 2 Eike Hein 2011-05-10 11:30:37 UTC
Could you explain in what way the genenric highlight facility falls short of your needs?
Comment 3 Matija Šuklje 2011-05-10 11:55:16 UTC
(In reply to comment #2)
> Could you explain in what way the genenric highlight facility falls short of
> your needs?

Hmmmm, you're right. It can work that way. It was just me who didn't set it right — due to a bug or own stupidity, I had (to) set Konvi to play a sound on *all* highlight notifications. Which meant that I would either get sound notifications on all highlights or none. But now I see it works on a per-highlight as well.

As far as *I* am concerned, this is a viable solution to this bug :]
Comment 4 Pavel 2013-03-31 07:36:41 UTC
The most inconvenient thing with "Highlight own nick" option for me is that it doesn't allow to play a sound.
I checked Changelog for Konversation 1.5-rc1 and it seems to not have changed.
I use 1.4 now.
Comment 5 Eike Hein 2013-03-31 07:55:44 UTC
Use the "Settings (Menu bar) -> Configure Notifications -> Nick written -> Play sound setting" to set a sound for the "Highlight own nick" event.
Comment 6 Pavel 2013-03-31 09:52:24 UTC
I tested the notification called "Highlight triggered".
It still only works on listed triggers, not on own nick. And there's no "Highlight own nick" event (at least not in 1.4).
Own nick is highlighted, but no sound is played.
Comment 7 Eike Hein 2013-03-31 09:55:29 UTC
The event is called "Nick written" as mentioned (or "Someone wrote your nick in a message" in the long column) and has been available for at least seven years or so. It's distinct from "Highlight triggered" which is for custom highlights.