Version: 2.0.0 (using Devel) OS: Linux Start the "Send images" kipi plugin with some images. Then remove all images from the list. The OK button is not disabled. When clicking on the OK button, a progress dialog opens with a "Cancel" button, but no progress is made. Reproducible: Always
Created attachment 58451 [details] Disable OK button when no image in ImagesList This patch could disable OK button when no image in list, it's works fine on my machine. This is my first patch for KDE, so please take a look it and give me more advice. Thanks,
Thanks I will take a look today... Gilles Caulier
Max, The patch is fine. A method can be simplified like this : void SendImagesDialog::slotImagesCountChanged() { enableButtonOk(!d->imagesPage->imagesList().isEmpty()); } Gilles Caulier
Git commit 279199ef2c04252aa00b20d58f77ceff6221e6b4 by Gilles Caulier. Committed on 30/03/2011 at 09:27. Pushed by cgilles into branch 'master'. apply patch #58451 from MAx Lin More private internal containers BUGS: 268316 M +12 -12 sendimages/emailpage.cpp M +2 -3 sendimages/emailpage.h M +3 -1 sendimages/emailsettingscontainer.h M +2 -2 sendimages/imageresize.cpp M +2 -3 sendimages/imageresize.h M +2 -2 sendimages/imagespage.cpp M +2 -2 sendimages/imagespage.h M +6 -6 sendimages/plugin_sendimages.cpp M +3 -5 sendimages/plugin_sendimages.h M +8 -8 sendimages/sendimages.cpp M +4 -4 sendimages/sendimages.h M +18 -10 sendimages/sendimagesdialog.cpp M +5 -5 sendimages/sendimagesdialog.h http://commits.kde.org/kipi-plugins/279199ef2c04252aa00b20d58f77ceff6221e6b4