Bug 268315 - xx MB field below "Mail program": Function unclear
Summary: xx MB field below "Mail program": Function unclear
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-SendByMail (show other bugs)
Version: 5.6.0
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-03-12 21:31 UTC by Michael G. Hansen
Modified: 2017-06-28 21:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.6.0

Attachments
Proposed patch. (2.89 KB, patch)
2012-03-24 21:32 UTC, Andrei Datcu 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Michael G. Hansen 2011-03-12 21:31:08 UTC 
Version:           2.0.0 (using Devel) 
OS:                Linux

In the "Mail" tab, the field "xx MB" below "Mail program" has neither a label nor a "What's this" explanation. IMHO it's not obvious what the function of this field is.

Reproducible: Always
Comment 1 Michael G. Hansen 2011-03-12 21:36:20 UTC 
The same is true for the field in the "Image properties" box below "Image file format". I assume it controls the JPEG quality.
Comment 2 caulier.gilles 2011-12-20 17:25:59 UTC 
Michael,

This file still valid using kipi-plugins 2.4 ?

Gilles Caulier
Comment 3 Michael G. Hansen 2011-12-27 15:28:41 UTC 
Still there in current git master.

Michael
Comment 4 Andrei Datcu 2012-03-24 21:32:28 UTC 
Created attachment 69867 [details]
Proposed patch.

I've added the labels. Please review my patch! Thanks!
Comment 5 caulier.gilles 2012-03-25 21:18:41 UTC 
smit,

Another little patch to test. I review it as well, and it sound fine for me.

If all is ok, please apply it to git/master.

Best

Gilles Caulier
Comment 6 Smit Mehta 2012-03-28 14:33:08 UTC 
Git commit 0d292c3582caa3811b6e793c9ee605d478d470b7 by smit mehta.
Committed on 28/03/2012 at 16:25.
Pushed by smitmehta into branch 'master'.

Adding intuitive labels in email program. Patch by Andrei Datcu. Reviewed and tested by Smit Mehta

M  +12   -4    sendimages/emailpage.cpp

http://commits.kde.org/kipi-plugins/0d292c3582caa3811b6e793c9ee605d478d470b7