Bug 268284 - ZoomSlider from statubar tooltip looks inconsistent
Summary: ZoomSlider from statubar tooltip looks inconsistent
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-MainView (show other bugs)
Version: 3.5.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-12 12:18 UTC by Andi Clemens
Modified: 2014-09-12 21:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andi Clemens 2011-03-12 12:18:06 UTC
Version:           2.0.0 (using KDE 4.6.1) 
OS:                Linux

Tooltips look different throughout digiKam. I think they should look the same (standard KDE design).

Normal tooltip:
http://www.flickr.com/photos/26732399@N05/5519613066/

digiKam tooltip:
http://www.flickr.com/photos/26732399@N05/5519613228/

The second example doesn't have to be transparent at all, since it will fade away anyway.
I'm sure we have more examples throughout the application.

For me it looks very "unprofessional", tooltips should look the same (an exception would be the big tooltip in the iconview of course).

Reproducible: Didn't try




OS: Linux (i686) release 2.6.37-ARCH
Compiler: gcc
Comment 1 Marcel Wiesweg 2011-03-12 13:16:53 UTC
The class is called DTipTracker, you will see it used in two places. I'm not quite why we cannot use QToolTip::show in these cases, but I guess there is a reason.
The big view tooltips are custom classes, but closely inspired from Qt source (the relevant Qt widget is not public API), that's why they look and behave identical.
If QToolTip::show is no viable solution for the use cases of DTipTracker, it should be modelled alongside DItemToolTip/ItemViewToolTip, possibly with a common base.
Comment 2 caulier.gilles 2011-03-13 12:11:12 UTC
Marcel,

When i implement tooltips support in thumbbar for showfoto (after that Renchi has implement iconview stuff), i tried to use QToolTip. But i see that tip cover generally a part of thumb, which is not a very nice effect. 

Re-implement this class can customize indeep where tip must be show without to cover thumb in all case.

Gilles Caulier
Comment 3 Marcel Wiesweg 2011-03-13 16:02:14 UTC
Gilles, from what I understand, the sort of tooltip Andi is complaining about is not the one for thumbnail views (which works fine IMO) but the DTipTracker used by only two widgets:
RatingFilter
DZoomBar
Comment 4 Andi Clemens 2011-03-13 16:55:37 UTC
Yes, I'm talking about the DTipTracker. I'm not sure if we even need this nowadays, the only place where we use these tooltip classes is the zoombar if I'm not wrong.
Comment 5 caulier.gilles 2011-12-19 13:58:48 UTC
Andi,

This file still valid using digiKam 2.4 ?

Gilles Caulier
Comment 6 Andi Clemens 2011-12-21 00:22:14 UTC
Yes, still valid
Comment 7 caulier.gilles 2012-01-25 13:48:40 UTC
To Marcel and Andi, #3,

The DToolTip is to show tip over a slider without to hide slider itself. In fact it still over slider and displayed until focus on slider is valid.

This widget come from Gwenview.

Gilles
Comment 8 caulier.gilles 2014-09-12 21:51:45 UTC
Git commit 1ae6ea3ecff3f42de9bc91fbf8c0d9ee5e499461 by Gilles Caulier.
Committed on 12/09/2014 at 21:51.
Pushed by cgilles into branch 'master'.

Use QToolTip properties to render DCursorTracker widget
FIXED-IN: 4.4.0

M  +1    -1    CMakeLists.txt
M  +2    -1    NEWS
M  +3    -3    app/filters/ratingfilter.cpp
M  +1    -1    app/filters/ratingfilter.h
R  +25   -12   libs/widgets/mainview/dcursortracker.cpp [from: libs/widgets/common/dcursortracker.cpp - 085% similarity]
R  +3    -14   libs/widgets/mainview/dcursortracker.h [from: libs/widgets/common/dcursortracker.h - 083% similarity]
M  +10   -10   libs/widgets/mainview/dzoombar.cpp
M  +1    -1    libs/widgets/mainview/dzoombar.h

http://commits.kde.org/digikam/1ae6ea3ecff3f42de9bc91fbf8c0d9ee5e499461