Bug 268166 - Put the "extract" service menu options into a separate submenu
Summary: Put the "extract" service menu options into a separate submenu
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Raphael Kubo da Costa
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-03-10 21:46 UTC by whatmeurgent
Modified: 2011-06-25 23:35 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.0


Attachments
Makes an extract submenu on dolphin menus. (2.03 KB, patch)
2011-05-24 23:11 UTC, Glen Kaukola
Details

Note You need to log in before you can comment on or make changes to this bug.
Description whatmeurgent 2011-03-10 21:46:58 UTC
Version:           unspecified (using KDE 4.6.1) 
OS:                Linux

This isn't a bug, just an aesthetic . . .

"open with ark" - shouldn't it be an entry in the "open with" submenu? 

There are three menu items for different options for "extract" - shouldn't they either be combined to a new sub-menu (similar to what is done for the compress options), OR put into the "actions" submenu, OR put into a submenu UNDER the actions submenu.

From Dolphin, right click on a tar.gz file:
Why is there a "compress" submenu entry for, um, compressed files? (I have listed this as a separate bug 268163)


Reproducible: Didn't try
Comment 1 Peter Penz 2011-03-10 22:18:44 UTC
Thanks for the suggestion, but this is out of scope of Dolphin: The Ark menu entries are provided by the Ark application itself.
Comment 2 Raphael Kubo da Costa 2011-03-11 01:37:15 UTC
> "open with ark" - shouldn't it be an entry in the "open with" submenu?

This only happens when Ark is the only application available to open a file of that given mimetype -- if I have File Roller installed as well, for example, there will be an "Open with" submenu listing both Ark and File Roller, whereas if only Ark is installed "Open with Ark" is shown in the top-level menu.

This behaviour looks sane to me. Does it look weird to you?

> There are three menu items for different options for "extract" - shouldn't they
> either be combined to a new sub-menu (similar to what is done for the compress
> options), OR put into the "actions" submenu, OR put into a submenu UNDER the
> actions submenu.

Indeed, creating an "Extract" submenu looks like the most reasonable option.

I'm confirming the report to tackle the latter.
Comment 3 Glen Kaukola 2011-05-24 23:09:49 UTC
Here's a patch sorta.  I tried my best with the languages, but could not cover them all.  I have a suspicion that editing that file by hand may be the wrong way to go about things?
Comment 4 Glen Kaukola 2011-05-24 23:11:34 UTC
Created attachment 60287 [details]
Makes an extract submenu on dolphin menus.

I'd post this to the review board but see no ark group or kdeutils group.
Comment 5 Raphael Kubo da Costa 2011-05-25 05:30:24 UTC
Thanks for the patch, sorry for not being able to test it here right now. The translations need not be manually added: KDE's infrastructure processes .desktop files and updates them with new translations when they are available automatically.

As for ReviewBoard, there is a kdeutils group in https://svn.reviewboard.kde.org. In fact, could you please submit it there so it's less likely to be forgotten?

Cheers!
Comment 6 Glen Kaukola 2011-05-26 00:44:11 UTC
Ok, therew it up on the review board:

https://svn.reviewboard.kde.org/r/6689/
Comment 7 Glen Kaukola 2011-05-27 22:39:27 UTC
Think I have it right this time:
https://svn.reviewboard.kde.org/r/6689/
Comment 8 Glen Kaukola 2011-06-08 03:19:40 UTC
Kdevelop creates .desktop files with all the translations, but with english in place of the the actual languages.  I wrongly assumed that's how things should be I guess.

Seems pretty trivial now, but anyhow, this should be right then:
https://svn.reviewboard.kde.org/r/6689/
Comment 9 Glen Kaukola 2011-06-25 23:14:45 UTC
Commited to master.