Created attachment 57815 [details] Proposed holiday_catalan Version: unspecified (using KDE 1.2) OS: Linux The holiday_catalan file has some issues: * Most holidays are not marked as such on the calendar (missing 'weekend') * "Dijous Sant" (easter-3) is marked as a holiday but it isn't. * "Pentecosta" is easter+50 (monday), not easter+49 (sunday) * "Dilluns de Pasqua" (easter+1) and "Sant Esteve" (December 26th) are missing. According to the file itself, this hasn't been touched since 1999. I wonder if I'm the last catalan using KOrganizer :-) Proposed holiday_catalan attached. I also changed the date format inside the file from month/day to day.month because day-month is the natural date order in catalan. Reproducible: Always Steps to Reproduce: Simply select the catalan holiday calendar. Actual Results: Dates like January 1st or 6th appear as working days. Expected Results: They should appear as holidays.
About to commit the corrections, but are you sure about Pentecost? Pentecost is the 5th Sunday after Easter (also called Whit Sunday in English), so 49 days is correct for that, but there is a separate religious holiday for Pentecost Monday (aka Whit Monday) that Google suggests may be known in Spanish as "Segunda Pascua" or "Pascua Granada" and in Catalan as "Dilluns de Pascua Granada" or "Segona Pasqua".
I'm not Catholic, so I thought about working holidays to elaborate. The "Segona Pasqua" is a 'joker' holiday, usually called when another holiday lays in Sunday, like this year with Christmas day. Also, when it is not a general catalan holiday, it usually is for some municipalities. As a moving date instead of usual other holidays, I find quite useful to mark it in the calendar without signalling it as holiday. Another common holiday between municipalities is Sant Jaume (July 25th), however as a fixed date I don't think it should be marked. However, the Catalan Wikipeadia lays Pentecosta in monday (counts "Pentecosta", meaning "fiftenth day", after Easter Sunday), however the English version includes Easter Sunday in the count of days. Now I'm confused. Please feel free to chage its name to "Segona Pasqua", which is also a more common name used in Catalonia. Also sorry for the dealy in the reply, I was out home this weekend :-)
Added the two missing entries to the plan2 file (http://commits.kde.org/kdepimlibs/7d182065410428765957dc8ee80a88bdff2162a3)