Bug 267865 - start kapman with escape or pause leaves text on level, crash when touched
Summary: start kapman with escape or pause leaves text on level, crash when touched
Status: RESOLVED FIXED
Alias: None
Product: kapman
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR crash
Target Milestone: ---
Assignee: Thomas Gallinari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-07 11:20 UTC by Tod Gome
Modified: 2011-07-01 17:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.6.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Gome 2011-03-07 11:20:37 UTC
Version:           unspecified (using KDE 4.5.1) 
OS:                Linux



Reproducible: Always

Steps to Reproduce:
start kapman, or on the start of a level, hit the ESCape or Pause key and the "Level #/Get Ready/etc." text stays on the level (Pause super imposed on top of it). Resume with Pause, escape, or arrow keys, and the text is still on the game screen. If kapman touches the text it crashes.

Actual Results:  
"Level" text and instructions text stays on the game field.

Expected Results:  
Text should disappear just as it does when you start the game by moving arrow keys, just as when you pause a started game, the word Pause is removed when you resume the game. The text should be removed when pause is displayed, or when kapman starts moving.

If you run kapman and hit escape or pause, the word Pause will be displayed over top of the Level/Get Ready text, and when you resume, the text remains on the level and the game crashes when kapman comes into contact with the text. You can only remove the text by avoiding the text till completion or till you die on a ghost restarting the level. This precludes access to the lower corridors surrounding the ghost pen and bonus items.
Comment 1 Frederik Schwarzer 2011-06-29 14:33:01 UTC
I do not have the crash here. The text remains here as well, though.

As I see it, the game does not have a distinct game state for the time before the start. So with the current code, I only see litte workarounds that improve the situations but not make it look consistent overall.

So I will commit a little fix that removes the text when pausing the game when the initial text is still there. On unpause the player immerdiately starts moving. That's how it is now and it will remain that way. I would like to see it differently (not being able to pause in initial state) but I am not going to digg that deep for now.

I hope that will at least fix the pressing need of getting rid of the text. :)
Comment 2 Frederik Schwarzer 2011-06-29 14:39:16 UTC
SVN commit 1238792 by schwarzer:

Fix bug where the initial text was not removed what pausing game.

BUG: 267865


 M  +3 -0      gamescene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1238792
Comment 3 Frederik Schwarzer 2011-06-29 15:00:25 UTC
SVN commit 1238793 by schwarzer:

Fix initial label bug.

(port to 4.6 branch)

The initial text was not removed when pausing the game and
then remained in place when unpausing and starting the game.

This should be done cleaner at some point, e.g. by creating
a distinctive state for INITIAL that does not allow pausing.

CCBUG: 267865


 M  +3 -0      gamescene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1238793
Comment 4 Frederik Schwarzer 2011-06-29 15:00:48 UTC
SVN commit 1238794 by schwarzer:

Fix initial label bug.

(port to trunk)

The initial text was not removed when pausing the game and
then remained in place when unpausing and starting the game.

This should be done cleaner at some point, e.g. by creating
a distinctive state for INITIAL that does not allow pausing.

CCBUG: 267865

 M  +4 -0      gamescene.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1238794
Comment 5 Tod Gome 2011-07-01 17:16:08 UTC
Hi, I'm on open SUSE 11.4 and kde4. The crash does not happen when I touch the text in 11.4 suse, however, it does happen in Ubuntu studio... 10.9.. I forget which version. I intended to upgrade to the latest ubuntu studio soon though. I guess it'll be fixed by then.

--- On Wed, 6/29/11, Frederik Schwarzer <schwarzer@kde.org> wrote:

From: Frederik Schwarzer <schwarzer@kde.org>
Subject: [Bug 267865] start kapman with escape or pause leaves text on level, crash when touched
To: neighbor.neighbor@yahoo.com
Date: Wednesday, June 29, 2011, 2:33 PM
https://bugs.kde.org/show_bug.cgi?id=267865


Frederik Schwarzer <schwarzer@kde.org>
changed:

           What 
  |Removed           
         |Added
----------------------------------------------------------------------------
             
   CC|         
               
  |schwarzer@kde.org




--- Comment #1 from Frederik Schwarzer <schwarzer kde
org>  2011-06-29 14:33:01 ---
I do not have the crash here. The text remains here as
well, though.

As I see it, the game does not have a distinct game state
for the time before
the start. So with the current code, I only see litte
workarounds that improve
the situations but not make it look consistent overall.

So I will commit a little fix that removes the text when
pausing the game when
the initial text is still there. On unpause the player
immerdiately starts
moving. That's how it is now and it will remain that way. I
would like to see
it differently (not being able to pause in initial state)
but I am not going to
digg that deep for now.

I hope that will at least fix the pressing need of getting
rid of the text. :)