Bug 267636 - Changing QtCurve presets from one to another causes plasma desktop crash
Summary: Changing QtCurve presets from one to another causes plasma desktop crash
Status: RESOLVED UPSTREAM
Alias: None
Product: plasma4
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR crash
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-04 16:57 UTC by Roman Bysh
Modified: 2011-03-19 19:21 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
plasma-desktop kcrash (4.49 KB, application/octet-stream)
2011-03-04 16:57 UTC, Roman Bysh
Details
Patch to fix QtCurve crash due to double-free (612 bytes, patch)
2011-03-05 20:58 UTC, Craig Drummond
Details
Patch to fix crash - better checkign when free'ing memory. (3.96 KB, patch)
2011-03-15 22:46 UTC, Craig Drummond
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bysh 2011-03-04 16:57:17 UTC
Created attachment 57673 [details]
plasma-desktop kcrash

Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

I am using a 64-bit machine with GeForce 8600 GTS

Every time I select QtCurve preset Agua -->OK and Apply then choose Curve OK and Apply buttons. Plasma desktop crashes including kwin, akonadi, nepomuk etc...
About 55 different pops ups appear.



Reproducible: Always

Steps to Reproduce:
1. Choose Widget Style QtCurve and click on Configure button
2. From Presets list choose Curve and click on OK and Apply buttons
3. Crash occurs


Actual Results:  
Crash occurs every time with over 50 to 55 crash pop ups.

Expected Results:  
Expect to switch to a different preset settings created by QtCurve without crash

Crash also occurs if you try to import a .qtcurve file.
Comment 1 Roman Bysh 2011-03-04 17:17:58 UTC
Correction to Steps to Reproduce

Reproducible: Always

Steps to Reproduce:
1. Choose Widget Style "QtCurve" and click on Configure button
2. From Presets list choose Agua and click on OK and Apply buttons
3. From Presets list choose Curve and click on OK and Apply buttons
4. Crash occurs
Comment 2 Roman Bysh 2011-03-04 18:10:20 UTC
Please note that this crash happens with:

A. The "nouveau" driver

and

B. The Nvidia proprietary driver
Comment 3 Aaron J. Seigo 2011-03-05 06:08:47 UTC
since all of those apps are crashing, that should be a hint that the bug is in the QtCurve style.
Comment 4 Craig Drummond 2011-03-05 14:23:19 UTC
Totally agree - this is a bug in QtCurve. Versions < 1.8.4 had a bug where (for certain configurations) memory was beeing free'd twice. Sorry.
Comment 5 Roman Bysh 2011-03-05 16:48:17 UTC
Since I will be using openSUSE 11.4. Do you know if this will be available to the openSUSE KDE Team for them to provide for KDE SC 4.6.1?

I know building KDE SC 4.6.1 will not be done until openSUSE 11.4 is out on Thursday March 10th, 2011.
Comment 6 Karsten König 2011-03-05 17:42:47 UTC
(In reply to comment #4)
> Totally agree - this is a bug in QtCurve. Versions < 1.8.4 had a bug where (for
> certain configurations) memory was beeing free'd twice. Sorry.

Do you have a single commit or patch we can apply? I don't know if we can get a version update through maintainance.
Roman QtCurve is a seperate component and not part of KDE, so this is unrelated if we get 4.6.1 into 11.4 or not
http://kde-look.org/content/show.php?content=40492
Comment 7 Roman Bysh 2011-03-05 19:31:23 UTC
Aaron and Craig,

Can you please provide Kasten with a single commit or patch? We are really pressed for time as openSUSE 11.4 is coming out Thursday, March 10th, 2011!
Comment 8 Karsten König 2011-03-05 20:23:42 UTC
Kasten means box in german, my parents were not that cruel ;-)

And no, 11.4 won't see a patch to this but only as an online update, it's too late for 11.4, which is already beeing pushed out to the mirrors afaik
Comment 9 Roman Bysh 2011-03-05 20:40:51 UTC
Sorry mate,

I was in the midst of an "edit and modify" about referring to the 11.4 updates. However, my finger slipped and send was pressed before I was able to finish ;-)
Comment 10 Craig Drummond 2011-03-05 20:58:55 UTC
Created attachment 57704 [details]
Patch to fix QtCurve crash due to double-free

The attached patch fixes the double-free issue - and should resolve the plasma crashes.
Comment 11 Karsten König 2011-03-05 21:53:50 UTC
Hm I should have checked that beforehand, I just noticed when I wanted to apply the patch, we are already shipping 0.8.4 so this must be something different
Comment 12 Craig Drummond 2011-03-15 22:46:05 UTC
Created attachment 58056 [details]
Patch to fix crash - better checkign when free'ing memory.

This second patch seems to fix the issue for me. Hopefully it is useful.
Comment 13 Roman Bysh 2011-03-19 19:21:14 UTC
This appears to be the correct fix. QtCurve no longer crashes when switching presets. And, it no longer crashes when importing ".qtcurve schemes".