Version: unspecified OS: Linux The functions min() and max(), mod(), and possibly all predefined variadic functions don't accept comma, or anything reasonable (e.g. semicolon) as argument separator. Reproducible: Always Steps to Reproduce: 1. Try creating a new Cartesian plot with the following formula: f(x) = max(x,2*x) Actual Results: The comma is highlighted in red, which means that it is not accepted as argument separator. Expected Results: The comma should be accepted as argument separator. Apparently locale related: comma is interpreted as decimal point. The following formula is accepted: f(x) = max(1,2) but it is interpreted as max(1+2/10). This is one of several problems related to the fact that kmplot apparently uses an amateur-ish formula parser. I will be filing a separate bug report for that. OS: Linux (i686) release 2.6.37-ARCH Compiler: gcc
*** This bug has been marked as a duplicate of bug 214527 ***
I don't think this should be marked as a duplicate of bug 214527. I reported that one earlier, but then I realized that the problem is more general, and reported this one.
*** Bug 214527 has been marked as a duplicate of this bug. ***
I think the policy should be that you are NOT allowed to resolve a bug by marking it a duplicate of an unconfirmed bug. How can you tell it is a duplicate if you have not spent enough time studying the supposed original bug to even confirm it?
Szczepan, kmplot currently has no maintainer. It does not make sense to keep duplicates open, as the number of open bugs would grow and raise the barrier for newcomers looking for a project to maintain.
(In reply to comment #5) > Szczepan, kmplot currently has no maintainer. Ah, that makes things different :( Thanks for for explaining.
So, how are we going to resolve this? The issue here is that the ',' char can be used as the decimal separator in many locales. I see three possibilities: A) force '.' as the decimal separator, as is done in KAlgebra (until someone complains about the locale issue there), B) use ';' as the multi-argument separator when "calling" the function, e.g. you declare "f(x,y)=" but use "f(x*2;12)" for the expression, C) require a space after ',' for multiple arguments, e.g. use f(x*2, 12).
Created attachment 100233 [details] remove conversion of the locale to "."
*** Bug 400068 has been marked as a duplicate of this bug. ***
Git commit 817c8700db18c19474095e4e4ffb025040b98491 by Yuri Chornoivan. Committed on 09/11/2018 at 21:48. Pushed by yurchor into branch 'Applications/18.12'. Fix using comma decimal separator in multiple argument functions Differential Revision: https://phabricator.kde.org/D16775 M +4 -1 kmplot/parser.cpp https://commits.kde.org/kmplot/817c8700db18c19474095e4e4ffb025040b98491