Bug 266911 - add space to suffix "MB" (" MB")
Summary: add space to suffix "MB" (" MB")
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-SendByMail (show other bugs)
Version: 5.6.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-22 19:22 UTC by Alexander Potashev
Modified: 2017-06-28 21:27 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.0.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2011-02-22 19:22:28 UTC 
Version:           1.8.0 (using KDE 4.6.0) 
OS:                Linux

Please, change "MB" to " MB" here:

--------------------
messages/extragear-graphics/kipiplugin_sendimages.po:64(#7)                
#: emailpage.cpp:119
msgid "MB"
--------------------

Reproducible: Always




OS: Linux (x86_64) release 2.6.37
Compiler: x86_64-pc-linux-gnu-gcc
Comment 1 Christoph Feck 2011-02-22 23:09:59 UTC 
Haven't looked at the code, but if possible, it should use KLocale::formatByteSize(), so that the user can chose between MiB and MB units.
Comment 2 Alexander Potashev 2011-02-23 18:10:44 UTC 
@Christoph:
" MB" is the suffix in a KIntNumInput (https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/sendimages/emailpage.cpp#L115), so it seems that KLocale::formatByteSize() is not enough to implement locale-aware suffixes.

But if someone will implement such suffixes, may be it's worth creating a new class "KByteSizeInput"?

P.S.: If hardcoded "MB" is a problem, Dolphin also suffers from it:
http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=0836aef33bc42d2f9d0f4d1f8b5b395359e39870&hb=9842f17d51c5aedd61cc19f096c845b6e997b339&f=dolphin/src/settings/general/previewssettingspage.cpp (lines 80, 88). Btw... those strings are also untranslatable.