Bug 266665 - Changing an accounting entry from "withdrawal" to "transfer" must negate amount
Summary: Changing an accounting entry from "withdrawal" to "transfer" must negate amount
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.5.2
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-19 13:34 UTC by Ian Hubbertz
Modified: 2011-09-28 19:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Hubbertz 2011-02-19 13:34:57 UTC
Version:           4.5.2 (using KDE 4.6.0) 
OS:                Linux

I'm using the aqbanking(HBCI) module for my bank account. Everything works fine and a lot of things are working automatically (kmymoney finds the correct category etc.), but there is one problem with transfers (e.g. ATM withdrawals).

A ATM withdrawal is a transfer to another ("Cash") account, so I change the withdrawal to "transfer" (BTW: this happens automatically if you select an "account" as category). The problem is, that a transfer is a positive transaction for this account. So, if you change a withdrawal to transfer, the sign of the amount must be changed.

Some problem also applies when transfering money to other accounts like credit card, custody account etc. 

Reproducible: Always

Steps to Reproduce:
1. Use aqbanking or QIF import to import new entries to your account.
2. Select an account instead of a category in the "Category" field
   ---> type is changed from "withdrawal" to "transfer"
3. Accept the change
4. The amount is now in the "deposit" column instead of the "payment" column and 

Actual Results:  
-> Transfers (e.g. ATM withdrawal) is summed up wrong for the account if the user does not change sign of the amount.

Expected Results:  
-> Amount should be negated, when changing a withdrawal to transfer so the user does not have to change the sign manually.

OS: Linux (x86_64) release 2.6.37-gentoo
Compiler: x86_64-pc-linux-gnu-gcc
Comment 1 Jack 2011-02-19 16:59:52 UTC
When you change the transaction type from withdrawal to transfer, note that at the beginning of the payee field, there is a dropdown.  If you switch this from "To" to "From" you won't have to negate the amount.

I do note there is an oddness with the transaction form.  If I click "Withdrawal" the payee header says "Pay to" and if I then switch to "Transfer" is stays "Pay to."  If I select "Deposit" it switches to "From" and stays "From" if I switch back to "Transfer."  If nothing else, this means that when you switch transaction types, you have to be careful to check the direction of the "To/From" choice.
Comment 2 Ian Hubbertz 2011-02-21 23:11:15 UTC
Yes, I would still consider this as bug, because changing from "withdrawal" to "transfer" should get the "direction" of the transfer right without user interaction.
Especially - like in my case - if the type of transaction is chosen automatically based on the category.

My workflow:
1. import the new data of my bank account 
For every new transaction:
  2. enter the category of the transaction.
  3. Accept the transaction

-->  In case of a ATM withdrawal the type of transaction is automatically changed to "transfer" because the money is transferred to my "cash account".

New user, especially if the used software like gnucash before, don't know the difference between in type. (in gnucash everything is an account, so there is no difference between an expense category or a real account (bank, credit or cash etc.)
Comment 3 Thomas Baumgart 2011-09-28 19:11:28 UTC
I just tried to duplicate the problem in 4.6.0. Must have been fixed in the meantime. If not, please re-open.