Bug 266645 - Wikipedia applet does not auto refresh when song changes in a stream.
Summary: Wikipedia applet does not auto refresh when song changes in a stream.
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View/Wikipedia (show other bugs)
Version: 2.4-GIT
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 2.4.1
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-19 08:10 UTC by Elbin Pallimalil
Modified: 2011-05-15 22:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.4.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elbin Pallimalil 2011-02-19 08:10:39 UTC
Version:           2.4.0 (using KDE 4.5.5) 
OS:                Linux

The wikipedia applet does not reload the info when the song changes in a stream. The "current title" applet auto updates when the song in a stream changes, so wikipedia applet should also be able to detect when the metadata in a stream changes.

This used to work as expected in previous versions, ie the wikipedia applet would update the info shown whenever the song in a stream changes.

This happens only when playing streams. When playing files the wikipedia info is automatically updated when the played file changes.

Reproducible: Always

Steps to Reproduce:
Enable the wikipedia applet.
Load a stream in amarok. http://stream-sd.radioparadise.com:9000/rp_96.ogg
Wikipedia applet shows the info for the current song being played.
Wait for the song to change.

Actual Results:  
Wikipedia applet still displays the info for the last song.

Expected Results:  
Wikipedia applet should show the info for the current song.
Comment 1 Myriam Schweingruber 2011-02-19 23:20:13 UTC
Using Amarok 2.4-git here: it apparently very much depends on the stream you us, my last.fm streams update correctly in Wikipedia, but there was indeed no update with the stream example you provided.
Comment 2 Mark Fraser 2011-03-19 11:38:49 UTC
I'm using Amarok 2.4 and when I tried last.fm last weekend, the Wikipedia entry didn't change when the song changed.
Comment 3 Elbin Pallimalil 2011-05-15 20:28:50 UTC
Patch committed to git
https://git.reviewboard.kde.org/r/100953/
Comment 4 Myriam Schweingruber 2011-05-15 22:55:49 UTC
Fixed by this commit:

Git commit 40fd3944b78f9721e625ad277e1c1a30ceb65859 by Ralf Engels.
Committed on 14/05/2011 at 18:26.
Pushed by rengels into branch 'master'.

Fix 266645: Update wikipedia applet when metadata in a stream changes.

WikipediaEnginePrivate has a member "Meta::TrackPtr currentTrack" and to check if an update is required this member is queried to get the previous track's data. This of course would not work as this member always returns the current data when a stream is being played.

Courtesy Elbin Pallimalil