Bug 266370 - Textarea maxlength & placeholder attributes do not work.
Summary: Textarea maxlength & placeholder attributes do not work.
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (other bugs)
Version First Reported In: 4.5.5
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Konqueror Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-15 11:51 UTC by bugzilla33
Modified: 2023-01-14 05:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
testcase (1.27 KB, text/html)
2011-02-15 11:51 UTC, bugzilla33
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bugzilla33 2011-02-15 11:51:57 UTC
Created attachment 57273 [details]
testcase

Version:           4.5.5 (using KDE 4.5.5) 
OS:                MS Windows

http://dev.w3.org/html5/markup/textarea.html

Textarea maxlength & placeholder attributes do not work.

maxlength tip: new line character (enter) should be regarded as a one character (length = 1).

Reproducible: Always

Steps to Reproduce:
Open: http://host0001.webd.pl/bugs/konqueror/maxlength-placeholder.htm

Actual Results:  
Textarea maxlength & placeholder attributes do not work.

Expected Results:  
Textarea maxlength & placeholder attributes should work.

OS: WindowsNT (i686) release Windows 7
Compiler: cl.exe
Comment 1 Maksim Orlovich 2011-02-19 23:44:30 UTC
Git commit 3dab9c74fdadcd1c0559dabfa081ffdb280f4218 by Maks Orlovich.
Committed on 19/02/2011 at 01:35.
Pushed by orlovich into branch 'master'.

khtml: Support HTML5 placeholder attribute.

CCBUG: 266370

M  +8    -0    khtml/ecma/kjs_html.cpp     
M  +3    -2    khtml/ecma/kjs_html.h     
M  +25   -0    khtml/html/html_formimpl.cpp     
M  +10   -0    khtml/html/html_formimpl.h     
M  +1    -0    khtml/misc/htmlattrs.in     
M  +1    -0    khtml/misc/htmlnames.cpp     
M  +397  -396  khtml/misc/htmlnames.h     
M  +3    -0    khtml/rendering/render_form.cpp     

http://commits.kde.org/kdelibs/3dab9c74fdadcd1c0559dabfa081ffdb280f4218
Comment 2 Andrea Iacovitti 2011-02-22 16:27:56 UTC
Is break statement missing after line 2944?
Patch:

--- html_formimpl.cpp
+++ html_formimpl.cpp
@@ -2942,6 +2942,7 @@
         break;
     case ATTR_PLACEHOLDER:
         setChanged();
+        break;
     default:
         HTMLGenericFormElementImpl::parseAttribute(attr);
     }
Comment 3 Andrew Crouthamel 2018-11-05 03:16:53 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Andrew Crouthamel 2018-11-17 04:57:52 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Justin Zobel 2022-12-15 05:48:55 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 6 Bug Janitor Service 2022-12-30 05:23:17 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2023-01-14 05:12:23 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!