Bug 265926 - [Patch] Routing tooltips are limited to two lines
Summary: [Patch] Routing tooltips are limited to two lines
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-09 21:00 UTC by Rolf Eike Beer
Modified: 2011-02-19 22:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.1 (KDE 4.6.1)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer 2011-02-09 21:00:01 UTC 
Version:           unspecified (using KDE 4.6.0) 
OS:                Linux

When doing routing in marble it and double click on one waypoint the note shown in the map view is limited to 2 lines so for longer street names or things like that you only get only parts of the information shown.

Some friendly developer notes from the IRC:
<Earthwings> i'm happy to receive patches, it shouldn't be too hard to do
<Earthwings> basically using qfontmetric and the given string
<Earthwings> could even be done in geopainter itself, so that the height would be an optional parameter when creating callouts

Reproducible: Always
Comment 1 Dennis Nienhüser 2011-02-19 20:45:24 UTC 
Patch is at http://reviewboard.kde.org/r/6525/
Comment 2 Dennis Nienhüser 2011-02-19 22:46:21 UTC 
SVN commit 1221644 by nienhueser:

Extend drawAnnotation() to calculate and use the optimal text height when an invalid height is passed. Use it for painting driving instructions in the map. Fixes long instructions being cut off. Reduce the rounded corner radius for a better text/bubble ratio.
BUG: 265926
REVIEW: 6525

 M  +6 -0      GeoPainter.cpp  
 M  +2 -0      GeoPainter.h  
 M  +2 -2      routing/RoutingLayer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1221644
Comment 3 Dennis Nienhüser 2011-02-19 22:50:58 UTC 
SVN commit 1221645 by nienhueser:

Extend drawAnnotation() to calculate and use the optimal text height when an invalid height is passed. Use it for painting driving instructions in the map. Fixes long instructions being cut off. Reduce the rounded corner radius for a better text/bubble ratio.
BUG: 265926
REVIEW: 6525
Backport of commit 1221644.

 M  +6 -0      GeoPainter.cpp  
 M  +2 -0      GeoPainter.h  
 M  +2 -2      routing/RoutingLayer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1221645
Comment 4 Dennis Nienhüser 2011-02-19 22:52:24 UTC 
SVN commit 1221647 by nienhueser:

Extend drawAnnotation() to calculate and use the optimal text height when an invalid height is passed. Use it for painting driving instructions in the map. Fixes long instructions being cut off. Reduce the rounded corner radius for a better text/bubble ratio.
BUG: 265926
REVIEW: 6525
Backport of commit 1221644.

 M  +6 -0      GeoPainter.cpp  
 M  +2 -0      GeoPainter.h  
 M  +2 -2      routing/RoutingLayer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1221647