Bug 265446 - Linking fails because of missing libs in CMakeLists.txt
Summary: Linking fails because of missing libs in CMakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui (show other bugs)
Version: git-latest
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 19:56 UTC by Martin Klapetek
Modified: 2012-07-06 12:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Diff with added libs (1.95 KB, text/plain)
2011-02-04 19:57 UTC, Martin Klapetek 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Klapetek 2011-02-04 19:56:21 UTC 
Version:           svn-playground (using KDE 4.6.0) 
OS:                Linux

Fedora has introduced new DSO-linking semantics of the gcc compiler, which basically needs all linked-to libs explicitly specified, see http://fedoraproject.org/wiki/Features/ChangeInImplicitDSOLinking for more details. Other distros slowly follows this change.

The libs missing are libQtXml and libkio, adding them directly to the CMakeLists.txt target_link_libraries() makes the linking ok, though I guess they should be added in a different way (using modules?). See the attached diff for details

Reproducible: Always
Comment 1 Martin Klapetek 2011-02-04 19:57:14 UTC 
Created attachment 56866 [details]
Diff with added libs
Comment 2 David Edmundson 2011-03-01 15:09:20 UTC 
Not accepting your patch directly because you're not using the KDE macros (i.e ${KDE_KIO_WHATEVER_IT_IS} should be used instead of just kio.

However I think we have fixed this all now in a recent commit. Could you check?
Comment 3 Martin Klapetek 2011-03-01 20:19:04 UTC 
Yes, this has been fixed. Also, I didn't know the KDE macro for kio, so I put just kio in there to make it compile ;)