Created attachment 56861 [details]
one attempt to address this, using cmake try_compile instead of regex
Version: unspecified (using KDE 4.6.0)
In newer versions of libjpeg-turbo (as is used in fedora), starting with 1.0.90, the definition of JPEB_LIB_VERSION has moved from jpeglib.h to jconfig.h , which breaks with the current incarnation of cmake regex'ing coming from bug #228483 and the following commit:
If this approach is agreeable, a similar implementation could be used elsewhere too (like kdegraphics/gwenview and corresponding bug #227313 ).
Created attachment 56863 [details]
minimalistic approach, simply add content from jconfig.h too
Looks like my minimalistic version doesn't work, nvm that one.
This also causes the kdegraphics-4.6.2 make to fail with libjpeg-turbo-1.1.0 but kdegraphics is fine with 1.0.1.
ping! any news on the porting to libjpeg-turbo?
OK, I've been using the try_compile patch variant for awhile. that seems safest to me.
can we merge it then? I can do it if you want (test included). Gilles?
Fwiw, there's a similar/copied check in kdegraphics/gwenview too
If something similar have been done to Gwenview, why to re-invent the wheel. If Gwenview sometion have been test, it must be adapted to digiKam as well...
Sorry, I meant that gwenview has the same problem here that digikam has. They are both broken wrt libjpeg-turbo.
so... do I have green light?
fyi, tracking gwenview elsewhere in bug #273217
Git commit 1ad9ae102ea1a82a72e31401fe840954a791219f by Riccardo Iaconelli.
Committed on 15/05/2011 at 16:18.
Pushed by ruphy into branch 'master'.
Don't fail CMake check: compile with libjpeg-turbo
Patch by Rex Dieter
Signed-off-by: Riccardo Iaconelli <firstname.lastname@example.org>
M +17 -11 CMakeLists.txt