Bug 265255 - qt-kde does not compile without qt-copy symlink
Summary: qt-kde does not compile without qt-copy symlink
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: Git
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 07:20 UTC by charlie
Modified: 2012-01-03 14:16 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description charlie 2011-02-03 07:20:58 UTC
Version:           git (using Devel) 
OS:                Linux

Update kdesrc-build so qt-kde can compile without using the symlink qt-copy to qt-kde (qt-kde will not compile without that symlink).

So instead of "module qt-copy" in the kdesrc-buildrc file allow building of "module qt-kde" to reflect the git://anongit.kde.org/qt-kde repository name.

Reproducible: Always
Comment 1 Michael Pyne 2011-02-03 22:56:03 UTC
Well, the module should be called qt-copy, not qt-kde (so it should not be a symlink at all).

This is required now as Qt uses a different build system from the rest of KDE, and I want to say there's a few other things that are slightly different for Qt builds than for others.

However kdesrc-build could be smarter about simply autodetecting when Qt or a clone of Qt is being built and respond accordingly, so I'll leave the bug open.
Comment 2 Michael Pyne 2012-01-03 03:33:20 UTC
Should be fixed with commit a2b25b883f7cade79a042d0094cdc91b7e30bd53 in git master.

As long as kdesrc-build detects that the module should be using a Qt build system it will take the Qt-specific actions required. You can see what build system kdesrc-build thinks is required if you pass '--verbose' as a command line option while building.
Comment 3 Michael Pyne 2012-01-03 03:42:12 UTC
Git commit a6807d9b8aa573f7ea5471102de06345e14ad331 by Michael Pyne.
Committed on 03/01/2012 at 04:39.
Pushed by mpyne into branch 'master'.

Do not require the Qt module to be named 'qt-copy'.

Pretty much what it says in the subject, although it depends at this
point on auto-detecting the proper build system correctly.

If you want to see what build system kdesrc-build thinks is required,
run with --verbose or --debug, and the build system will be displayed
with the module name during the build phase.

I mistakenly said an earlier commit implemented this feature though,
it's actually *this* commit.

M  +1    -2    README
M  +10   -10   kdesrc-build
M  +1    -1    kdesrc-build-setup
M  +15   -10   kdesrc-build-test.pl
M  +8    -9    kdesrc-buildrc-sample

http://commits.kde.org/kdesrc-build/a6807d9b8aa573f7ea5471102de06345e14ad331
Comment 4 charlie 2012-01-03 14:16:06 UTC
Good job.