Bug 264698 - [PATCH] remove KDE3/Qt3 dependency
Summary: [PATCH] remove KDE3/Qt3 dependency
Status: REPORTED
Alias: None
Product: kiconedit
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR wishlist
Target Milestone: ---
Assignee: Thomas Tanghus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-29 00:23 UTC by David
Modified: 2013-04-26 07:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
diff (80.73 KB, patch)
2011-01-29 00:23 UTC, David
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David 2011-01-29 00:23:57 UTC
Created attachment 56594 [details]
diff

Version:           unspecified (using Devel) 
OS:                Linux

I made a patch, that removes old KDE3 and Qt3. Consequently fixes few bugs in background settings (PaletteToolBar and KTemplateConfig) and shows selected color. I also made change in undo history (remembers "draw one dot" with Freehand).
Patch changes almost all files.
Diff made against Directory revision:	1214341

(sorry for my bad English)

Reproducible: Always




It's my first patch, so I'm not sure if I didn't add some new bugs, but what I've tested works better or same as svn version.
(tested on Kubuntu 10.10 with kde 4.6 from ppa)
Comment 1 Burkhard Lück 2013-04-26 07:59:27 UTC
Hi David,

i have applied your patch to actual svn and judging from my quick tests kiconedit seems to work better with your patch.

With the kde3/qt3 dependencies kiconedit will be removed from extragear graphics sooner or later.

Thus it would be important to get your patch into svn to keep kiconedit alive.

Sadly the bug assignee is obviously no more active and did not react to your patch.

So you should try to get in touch with some devels from kdegraphics / extragear to get your patch in