Created attachment 56384 [details] Patch fixing the problem. Version: 1.8.0 (using KDE 4.5.4) OS: All In png-1.5, the prototype for png_set_iCCCP changed. The fifth argument was a png_charp and is now a png_bytep. Reproducible: Always Steps to Reproduce: Compile digikam against png-1.5. Actual Results: Here's the output from digikam-1.6.0, but the code is the same in SVN: libs/dimg/loaders/pngloader.cpp: In member function 'virtual bool Digikam::PNGLoader::load(const QString&, Digikam::DImgLoaderObserver*)': libs/dimg/loaders/pngloader.cpp:501: error: invalid conversion from 'char**' to 'png_byte**' libs/dimg/loaders/pngloader.cpp:501: error: initializing argument 5 of 'png_uint_32 png_get_iCCP(const png_struct*, const png_info*, char**, int*, png_byte**, png_uint_32*)' libs/dimg/loaders/pngloader.cpp: In member function 'virtual bool Digikam::PNGLoader::save(const QString&, Digikam::DImgLoaderObserver*)': libs/dimg/loaders/pngloader.cpp:733: error: invalid conversion from 'char*' to 'const png_byte*' libs/dimg/loaders/pngloader.cpp:733: error: initializing argument 5 of 'void png_set_iCCP(png_struct*, png_info*, const char*, int, const png_byte*, png_uint_32)' Expected Results: Successful compilation :) I've attached a patch that fixes the problem with 1.5.0. It probably needs changes to still work against older versions (which I don't have installed).
Created attachment 56390 [details] Patch fixing the problem, but supporting libpng 1.4 or earlier Hi Thomas, Thanks for reporting. Attached is a new patch that should work with 1.4 and 1.5. Could you double-check it works on 1.5? Thanks, Andrew
Andrew, If patch work fine with 1.5, please apply it to trunk. I will sync GoSC2010 later... Gilles
Andrew, your patch works fine with png-1.5. Thanks!
SVN commit 1216968 by coles: Support for libpng 1.5 - the type for iCCP data has changed. BUG: 264181 M +9 -2 pngloader.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1216968