Bug 264096 - [PATCH] K3b small fixes for windows build
Summary: [PATCH] K3b small fixes for windows build
Status: RESOLVED NOT A BUG
Alias: None
Product: k3b
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Michał Małek
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-01-23 18:02 UTC by Andrius
Modified: 2011-01-29 01:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
patch for windows build (3.92 KB, patch)
2011-01-23 18:02 UTC, Andrius 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius 2011-01-23 18:02:19 UTC 
Created attachment 56353 [details]
patch for windows build

Version:           git (using Devel) 
OS:                MS Windows

Somehow git reviewboard does not let me upload this patch, please review. Those are some small fixes for building K3b under Windows, tested under MSVC 2008 only

Reproducible: Always

Steps to Reproduce:
n/a.

Actual Results:  
n/a.

Expected Results:  
n/a.

n/a.
Comment 1 Michał Małek 2011-01-27 23:34:22 UTC 
Hi,
Your patch lists files with no changes e.g.:
diff --git a/libk3b/CMakeLists.txt b/libk3b/CMakeLists.txt
diff --git a/libk3b/tools/k3bcdparanoialib.h b/libk3b/tools/k3bcdparanoialib.h
diff --git a/libk3b/tools/qprocess/k3bqprocess.cpp b/libk3b/tools/qprocess/k3bqprocess.cpp

That's why ReviewBoard haven't accepted it. Please remove these lines and resubmit it on git.reviewboard.kde.org so we could discuss the patch in details. Thanks!
Comment 2 Andrius 2011-01-29 01:40:16 UTC 
Review request opened:
http://git.reviewboard.kde.org/r/100457/

Thanks!